2015-11-14 23:16:57

by Fengguang Wu

[permalink] [raw]

Subject: drivers/staging/wilc1000/host_interface.c:4135:5: error: conflicting types for 'host_int_init'

---

Hi Glen,

FYI, the error/warning still remains.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 12b76f3bf336388916ddf8047156f9e9993ff4e9
commit: d5382219138db78b82631501b0f614e5fd012ad1 staging: wilc1000: host_int_init: add argument net_device
date: 2 weeks ago
config: i386-allyesconfig (attached as .config)
reproduce:
git checkout d5382219138db78b82631501b0f614e5fd012ad1
# save the attached .config to linux build tree
make ARCH=i386

All errors (new ones prefixed by >>):

In file included from drivers/staging/wilc1000/host_interface.c:5:0:
drivers/staging/wilc1000/host_interface.h:914:50: warning: 'struct net_device' declared inside parameter list
s32 host_int_init(struct net_device *dev, struct host_if_drv **phWFIDrv);
^
drivers/staging/wilc1000/host_interface.h:914:50: warning: its scope is only this definition or declaration, which is probably not what you want
>> drivers/staging/wilc1000/host_interface.c:4135:5: error: conflicting types for 'host_int_init'
s32 host_int_init(struct net_device *dev, struct host_if_drv **hif_drv_handler)
^
In file included from drivers/staging/wilc1000/host_interface.c:5:0:
drivers/staging/wilc1000/host_interface.h:914:5: note: previous declaration of 'host_int_init' was here
s32 host_int_init(struct net_device *dev, struct host_if_drv **phWFIDrv);
^

vim +/host_int_init +4135 drivers/staging/wilc1000/host_interface.c

4129
4130 void host_int_send_network_info_to_host
4131 (u8 *macStartAddress, u16 u16RxFrameLen, s8 s8Rssi)
4132 {
4133 }
4134
> 4135 s32 host_int_init(struct net_device *dev, struct host_if_drv **hif_drv_handler)
4136 {
4137 s32 result = 0;
4138 struct host_if_drv *hif_drv;

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

---

Attachments:

(No filename) (1.96 kB)
.config.gz (49.95 kB)
Download all attachments

2015-11-16 02:01:26

by Glen Lee

[permalink] [raw]

Subject: Re: drivers/staging/wilc1000/host_interface.c:4135:5: error: conflicting types for 'host_int_init'

---

Hi fengguang,

This was fixed on staging-testing branch but not yet merged.

8224ec3e05b626b1b18ed0c107f2a2b1da979553 fixes this error also.

regards,
glen lee.


On 2015년 11월 15일 08:15, kbuild test robot wrote:
> Hi Glen,
>
> FYI, the error/warning still remains.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 12b76f3bf336388916ddf8047156f9e9993ff4e9
> commit: d5382219138db78b82631501b0f614e5fd012ad1 staging: wilc1000: host_int_init: add argument net_device
> date: 2 weeks ago
> config: i386-allyesconfig (attached as .config)
> reproduce:
> git checkout d5382219138db78b82631501b0f614e5fd012ad1
> # save the attached .config to linux build tree
> make ARCH=i386
>
> All errors (new ones prefixed by >>):
>
> In file included from drivers/staging/wilc1000/host_interface.c:5:0:
> drivers/staging/wilc1000/host_interface.h:914:50: warning: 'struct net_device' declared inside parameter list
> s32 host_int_init(struct net_device *dev, struct host_if_drv **phWFIDrv);
> ^
> drivers/staging/wilc1000/host_interface.h:914:50: warning: its scope is only this definition or declaration, which is probably not what you want
>>> drivers/staging/wilc1000/host_interface.c:4135:5: error: conflicting types for 'host_int_init'
> s32 host_int_init(struct net_device *dev, struct host_if_drv **hif_drv_handler)
> ^
> In file included from drivers/staging/wilc1000/host_interface.c:5:0:
> drivers/staging/wilc1000/host_interface.h:914:5: note: previous declaration of 'host_int_init' was here
> s32 host_int_init(struct net_device *dev, struct host_if_drv **phWFIDrv);
> ^
>
> vim +/host_int_init +4135 drivers/staging/wilc1000/host_interface.c
>
> 4129
> 4130 void host_int_send_network_info_to_host
> 4131 (u8 *macStartAddress, u16 u16RxFrameLen, s8 s8Rssi)
> 4132 {
> 4133 }
> 4134
>> 4135 s32 host_int_init(struct net_device *dev, struct host_if_drv **hif_drv_handler)
> 4136 {
> 4137 s32 result = 0;
> 4138 struct host_if_drv *hif_drv;
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation