2015-11-17 02:44:50

by Jiada Wang

Subject: [PATCH v2] thermal: of-thermal: Reduce log level for message when can't find thermal zone

Some systems register thermal zone by themself and don't need to
have thermal zones node in DT. Therefore reduce the log level from
ERROR to DEBUG when thermal zone node can't be found in
of_thermal_destroy_zones().

Signed-off-by: Jiada Wang <[email protected]>
---
drivers/thermal/of-thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c
index 42b7d42..be4eedc 100644
--- a/drivers/thermal/of-thermal.c
+++ b/drivers/thermal/of-thermal.c
@@ -964,7 +964,7 @@ void of_thermal_destroy_zones(void)

np = of_find_node_by_name(NULL, "thermal-zones");
if (!np) {
- pr_err("unable to find thermal zones\n");
+ pr_debug("unable to find thermal zones\n");
return;
}

--
2.4.5

2015-11-17 03:37:14

by Eduardo Valentin

Subject: Re: [PATCH v2] thermal: of-thermal: Reduce log level for message when can't find thermal zone

On Tue, Nov 17, 2015 at 11:43:34AM +0900, Jiada Wang wrote:
> Some systems register thermal zone by themself and don't need to
> have thermal zones node in DT. Therefore reduce the log level from
> ERROR to DEBUG when thermal zone node can't be found in
> of_thermal_destroy_zones().


This is already applied [1]. I applied V1 though.
What is the difference from v1?

[1] -
https://git.kernel.org/cgit/linux/kernel/git/evalenti/linux-soc-thermal.git/commit/?h=fixes&id=285249884ec19480f99c011d223760bb1fc865a2

BR,

Eduardo Valentin

2015-11-17 04:52:24

by Jiada Wang

Subject: Re: [PATCH v2] thermal: of-thermal: Reduce log level for message when can't find thermal zone

Hello

On 11/17/2015 12:37 PM, Eduardo Valentin wrote:
> On Tue, Nov 17, 2015 at 11:43:34AM +0900, Jiada Wang wrote:
>> Some systems register thermal zone by themself and don't need to
>> have thermal zones node in DT. Therefore reduce the log level from
>> ERROR to DEBUG when thermal zone node can't be found in
>> of_thermal_destroy_zones().
>
>
> This is already applied [1]. I applied V1 though.
> What is the difference from v1?
>
fixed typo in commit subject
"fine" -> "find"

Thanks,
Jiada
> [1] -
> https://git.kernel.org/cgit/linux/kernel/git/evalenti/linux-soc-thermal.git/commit/?h=fixes&id=285249884ec19480f99c011d223760bb1fc865a2
>
> BR,
>
> Eduardo Valentin
>