2015-11-19 02:44:21

by Caesar Wang

[permalink] [raw]
Subject: Re: [PATCH v4 3/3] ARM: dts: rockchip: Add the OTP gpio pinctrl

Hi Heiko,

在 2015年10月25日 15:55, Heiko Stübner 写道:
> Am Freitag, 23. Oktober 2015, 08:25:08 schrieb Doug Anderson:
>> On Fri, Oct 23, 2015 at 4:25 AM, Caesar Wang <[email protected]> wrote:
>>> Add the "init" anf "sleep" pinctrl as the OTP gpio state.
>>> We need the OTP pin is gpio state before resetting the TSADC controller,
>>> since the tshut polarity will generate a high signal.
>>>
>>> "init" pinctrl property is defined by Doug's Patch[0].
>>>
>>> Patch[0]:
>>> https://patchwork.kernel.org/patch/7454311/
>>>
>>> Signed-off-by: Caesar Wang <[email protected]>
>>> Reviewed-by: Douglas Anderson <[email protected]>
>>> ---
>>>
>>> Changes in v4: None
>>>
>>> Changes in v3:
>>> - Add the "sleep" pinctrl as the gpio state in PATCH[3/3]
>>>
>>> Changes in v2:
>>> - Add some commits for more obvious in PATCH[2/2]
>>>
>>> Changes in v1:
>>> - As the Doug comments, drop the thermal driver patchs since
>>>
>>> we can with pinctrl changing to work.
>>>
>>> - As the Doug's patch to add the 'init' property.
>>>
>>> arch/arm/boot/dts/rk3288.dtsi | 10 ++++++++--
>>> 1 file changed, 8 insertions(+), 2 deletions(-)
>> I realized that the subject of this patch should probably contain the
>> word rk3288, but I presume Heiko would rather add that himself than
>> for you to spin this again. ;)
> yep :-) ... no need to respin for such an easy change

That's seem this patch didn't merge into your v4.5-armsoc/soc branch.:-)

I guess this patch should merge into kernel-4.4 since the Patch[1/3] /
[2/3] have been merged into 4.4-rc1.:-P

>
> _______________________________________________
> Linux-rockchip mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-rockchip


--
Thanks,
Caesar


2015-11-19 04:57:21

by Heiko Stuebner

[permalink] [raw]
Subject: Re: [PATCH v4 3/3] ARM: dts: rockchip: Add the OTP gpio pinctrl

Hi Caesar,

Am Donnerstag, 19. November 2015, 10:44:02 schrieb Caesar Wang:
> 在 2015年10月25日 15:55, Heiko Stübner 写道:
> > Am Freitag, 23. Oktober 2015, 08:25:08 schrieb Doug Anderson:
> >> On Fri, Oct 23, 2015 at 4:25 AM, Caesar Wang <[email protected]> wrote:
> >>> Add the "init" anf "sleep" pinctrl as the OTP gpio state.
> >>> We need the OTP pin is gpio state before resetting the TSADC controller,
> >>> since the tshut polarity will generate a high signal.
> >>>
> >>> "init" pinctrl property is defined by Doug's Patch[0].
> >>>
> >>> Patch[0]:
> >>> https://patchwork.kernel.org/patch/7454311/
> >>>
> >>> Signed-off-by: Caesar Wang <[email protected]>
> >>> Reviewed-by: Douglas Anderson <[email protected]>
> >>> ---
> >>>
> >>> Changes in v4: None
> >>>
> >>> Changes in v3:
> >>> - Add the "sleep" pinctrl as the gpio state in PATCH[3/3]
> >>>
> >>> Changes in v2:
> >>> - Add some commits for more obvious in PATCH[2/2]
> >>>
> >>> Changes in v1:
> >>> - As the Doug comments, drop the thermal driver patchs since
> >>>
> >>> we can with pinctrl changing to work.
> >>>
> >>> - As the Doug's patch to add the 'init' property.
> >>>
> >>> arch/arm/boot/dts/rk3288.dtsi | 10 ++++++++--
> >>> 1 file changed, 8 insertions(+), 2 deletions(-)
> >> I realized that the subject of this patch should probably contain the
> >> word rk3288, but I presume Heiko would rather add that himself than
> >> for you to spin this again. ;)
> > yep :-) ... no need to respin for such an easy change
>
> That's seem this patch didn't merge into your v4.5-armsoc/soc branch.:-)
>
> I guess this patch should merge into kernel-4.4 since the Patch[1/3] /
> [2/3] have been merged into 4.4-rc1.:-P

thanks for the reminder :-)

It seems I didn't get a notice when the core thermal changes were merged, so
this patch seems to have dropped of my radar. It is clearly a fix for a real
issue, so I've added it to my fixes branch for 4.4.


Heiko