2015-11-19 06:15:06

by Vineet Gupta

[permalink] [raw]
Subject: Re: [PATCH] include: asm-generic: page.h: Remove useless get_user_page and free_user_page

On Thursday 19 November 2015 01:10 AM, Chen Gang wrote:
> From ba7c00c4cb976109b6a35812ce9649aaeda81e2d Mon Sep 17 00:00:00 2001
> From: Chen Gang <[email protected]>
> Date: Thu, 19 Nov 2015 03:24:42 +0800
> Subject: [PATCH] include: asm-generic: page.h: Remove useless get_user_page and free_user_page
>
> They are not symmetric with each other, neither are used in real world
> (can not be found by grep command in source code root directory), so
> remove them.
>
> Signed-off-by: Chen Gang <[email protected]>
> ---
> arch/arc/include/asm/page.h | 3 ---
> arch/arm/include/asm/page-nommu.h | 3 ---
> arch/frv/include/asm/page.h | 3 ---
> arch/m68k/include/asm/page_mm.h | 3 ---
> arch/m68k/include/asm/page_no.h | 3 ---
> arch/openrisc/include/asm/page.h | 3 ---
> include/asm-generic/page.h | 3 ---
> 7 files changed, 21 deletions(-)

So this is one huge patch touching several arches with potential to cause
conflicts when merged. Can u divy them up and then the maintainers can simply
merge them individually given there is no common dependency !