2019-12-19 05:14:52

by John Hubbard

[permalink] [raw]
Subject: [PATCH] move_pages.2: remove ENOENT from the list of possible return values

Linux kernel commit e78bbfa82624 ("mm: stop returning -ENOENT from
sys_move_pages() if nothing got migrated") had the effect of *never*
returning -ENOENT, in any situation. So we need to update the man page
to reflect that ENOENT is not a possible return value.

Acked-by: Michal Hocko <[email protected]>
Cc: Brice Goglin <[email protected]>
Cc: Yang Shi <[email protected]>
Cc: Christoph Lameter <[email protected]>
Signed-off-by: John Hubbard <[email protected]>
---

Hi,

This fix for the man page was ACK'd by Michal, here:

https://lore.kernel.org/r/[email protected]

thanks,
John Hubbard
NVIDIA

man2/move_pages.2 | 6 ------
1 file changed, 6 deletions(-)

diff --git a/man2/move_pages.2 b/man2/move_pages.2
index 2d96468fa..1bf1053f2 100644
--- a/man2/move_pages.2
+++ b/man2/move_pages.2
@@ -191,12 +191,6 @@ was specified or an attempt was made to migrate pages of a kernel thread.
.B ENODEV
One of the target nodes is not online.
.TP
-.B ENOENT
-No pages were found that require moving.
-All pages are either already
-on the target node, not present, had an invalid address or could not be
-moved because they were mapped by multiple processes.
-.TP
.B EPERM
The caller specified
.B MPOL_MF_MOVE_ALL
--
2.24.1


Subject: Re: [PATCH] move_pages.2: remove ENOENT from the list of possible return values

Hello John,

On 12/19/19 6:13 AM, John Hubbard wrote:
> Linux kernel commit e78bbfa82624 ("mm: stop returning -ENOENT from
> sys_move_pages() if nothing got migrated") had the effect of *never*
> returning -ENOENT, in any situation. So we need to update the man page
> to reflect that ENOENT is not a possible return value.
>
> Acked-by: Michal Hocko <[email protected]>
> Cc: Brice Goglin <[email protected]>
> Cc: Yang Shi <[email protected]>
> Cc: Christoph Lameter <[email protected]>
> Signed-off-by: John Hubbard <[email protected]>
> ---
>
> Hi,
>
> This fix for the man page was ACK'd by Michal, here:
>
> https://lore.kernel.org/r/[email protected]

Thanks. Patch applied.

Cheers,

Michael

> man2/move_pages.2 | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/man2/move_pages.2 b/man2/move_pages.2
> index 2d96468fa..1bf1053f2 100644
> --- a/man2/move_pages.2
> +++ b/man2/move_pages.2
> @@ -191,12 +191,6 @@ was specified or an attempt was made to migrate pages of a kernel thread.
> .B ENODEV
> One of the target nodes is not online.
> .TP
> -.B ENOENT
> -No pages were found that require moving.
> -All pages are either already
> -on the target node, not present, had an invalid address or could not be
> -moved because they were mapped by multiple processes.
> -.TP
> .B EPERM
> The caller specified
> .B MPOL_MF_MOVE_ALL
>


--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/