2015-11-23 17:46:09

by Jitendra

[permalink] [raw]
Subject: [PATCH] staging: comedi: comedilib.h: Coding style warning fix for block comments

This patch is to comedilib.h file that fixes up following warnings
reported by checkpatch.pl :
I) Block comments use * on subsequent lines

Signed-off-by: Jitendra Kumar Khasdev <[email protected]>
---
drivers/staging/comedi/comedilib.h | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/drivers/staging/comedi/comedilib.h b/drivers/staging/comedi/comedilib.h
index 56baf85..e530028 100644
--- a/drivers/staging/comedi/comedilib.h
+++ b/drivers/staging/comedi/comedilib.h
@@ -1,20 +1,20 @@
/*
- linux/include/comedilib.h
- header file for kcomedilib
-
- COMEDI - Linux Control and Measurement Device Interface
- Copyright (C) 1998-2001 David A. Schleef <[email protected]>
-
- This program is free software; you can redistribute it and/or modify
- it under the terms of the GNU General Public License as published by
- the Free Software Foundation; either version 2 of the License, or
- (at your option) any later version.
-
- This program is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
- GNU General Public License for more details.
-*/
+ * linux/include/comedilib.h
+ *
+ * COMEDI - Linux Control and Measurement Device Interface
+ * Copyright (C) 1998-2001 David A. Schleef <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ */

#ifndef _LINUX_COMEDILIB_H
#define _LINUX_COMEDILIB_H
--
1.9.1


2015-11-23 18:41:32

by Ian Abbott

[permalink] [raw]
Subject: Re: [PATCH] staging: comedi: comedilib.h: Coding style warning fix for block comments

On 23/11/15 17:45, Jitendra Kumar Khasdev wrote:
> This patch is to comedilib.h file that fixes up following warnings
> reported by checkpatch.pl :
> I) Block comments use * on subsequent lines
>
> Signed-off-by: Jitendra Kumar Khasdev <[email protected]>
> ---
> drivers/staging/comedi/comedilib.h | 32 ++++++++++++++++----------------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedilib.h b/drivers/staging/comedi/comedilib.h
> index 56baf85..e530028 100644
> --- a/drivers/staging/comedi/comedilib.h
> +++ b/drivers/staging/comedi/comedilib.h
> @@ -1,20 +1,20 @@
> /*
> - linux/include/comedilib.h
> - header file for kcomedilib
> -
> - COMEDI - Linux Control and Measurement Device Interface
> - Copyright (C) 1998-2001 David A. Schleef <[email protected]>
> -
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License as published by
> - the Free Software Foundation; either version 2 of the License, or
> - (at your option) any later version.
> -
> - This program is distributed in the hope that it will be useful,
> - but WITHOUT ANY WARRANTY; without even the implied warranty of
> - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - GNU General Public License for more details.
> -*/
> + * linux/include/comedilib.h
> + *
> + * COMEDI - Linux Control and Measurement Device Interface
> + * Copyright (C) 1998-2001 David A. Schleef <[email protected]>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + */
>
> #ifndef _LINUX_COMEDILIB_H
> #define _LINUX_COMEDILIB_H
>

You removed the "header file for kcomedilib" line, which was probably
more useful than the "linux/include/comedilib.h" line, especially as the
pathname "linux/include/comedilib.h" isn't very accurate!

--
-=( Ian Abbott @ MEV Ltd. E-mail: <[email protected]> )=-
-=( Web: http://www.mev.co.uk/ )=-