On 12/10/15 23:43, Julia Lawall wrote:
> Device node iterators perform an of_node_put on each iteration, so putting
> an of_node_put before a continue results in a double put.
>
> A simplified version of the semantic match that finds this problem is as
> follows (http://coccinelle.lip6.fr):
>
> // <smpl>
> @@
> expression root,e;
> local idexpression child;
> iterator i;
> @@
>
> i(..., child, ...) {
> ... when != of_node_get(child)
> * of_node_put(child);
> ...
> * continue;
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <[email protected]>
>
> ---
> drivers/video/fbdev/omap2/dss/omapdss-boot-init.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Thanks, queued for 4.5.
Tomi