2015-11-19 22:03:38

by Prakash, Prashanth

[permalink] [raw]
Subject: Re: [PATCH v2 5/5] ACPI / processor_idle: Add support for Low Power Idle(LPI) states

Hi Sudeep,

On 10/27/2015 8:09 AM, Sudeep Holla wrote:
> Hi Prashanth,
>
> On 27/10/15 00:21, Prakash, Prashanth wrote:
>> Hi Sudeep,
>>
>> While testing with these patches everything looked fine except that we
>> are flattening all the LPI
>> states even if it is disabled. I added a simple check to fix it. Please
>> let me know if you have any
>> feedback on the same.
>>
>
> Looks good to me and thanks for the nice catch. I completely missed to
> handle that case. Is it OK if I fold this patch into the next version ?
>
> I have worked on Ashwin's comments, but was waiting to get some feedback
> from Rafael before I post newer version.
>
Did you had an opportunity to update the LPI patch set? Please let me know
if you need any help in test/verification of the new patch set.

--
Thanks,
Prashanth


2015-11-26 11:09:26

by Sudeep Holla

[permalink] [raw]
Subject: Re: [PATCH v2 5/5] ACPI / processor_idle: Add support for Low Power Idle(LPI) states

Hi Prashanth,

On 19/11/15 22:03, Prakash, Prashanth wrote:
> Hi Sudeep,
>
> On 10/27/2015 8:09 AM, Sudeep Holla wrote:
>> Hi Prashanth,
>>
>> On 27/10/15 00:21, Prakash, Prashanth wrote:
>>> Hi Sudeep,
>>>
>>> While testing with these patches everything looked fine except that we
>>> are flattening all the LPI
>>> states even if it is disabled. I added a simple check to fix it. Please
>>> let me know if you have any
>>> feedback on the same.
>>>
>>
>> Looks good to me and thanks for the nice catch. I completely missed to
>> handle that case. Is it OK if I fold this patch into the next version ?
>>
>> I have worked on Ashwin's comments, but was waiting to get some feedback
>> from Rafael before I post newer version.
>>
> Did you had an opportunity to update the LPI patch set? Please let me know
> if you need any help in test/verification of the new patch set.
>

Sorry for the late response, was off for 3 weeks. I will post the new
version early next week after some testing.

--
Regards,
Sudeep