This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.
Signed-off-by: Luis de Bethencourt <[email protected]>
---
Hi,
This is a resend of a patch from October 20th [0]
I am adding Andrew Morton to the CC list as was recommended at the Korea Linux
Forum.
This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
that information so modules have the correct aliases built-in and
autoloading works correctly.
A longer explanation by Javier Canillas can be found here:
https://lkml.org/lkml/2015/7/30/519
A multitude of similar patches have been merged for other drivers, search
the git log for "module autoload for OF platform driver".
Thanks,
Luis
[0] https://lkml.org/lkml/2015/10/20/478
drivers/gpu/drm/imx/imx-tve.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c
index e671ad3..f959714 100644
--- a/drivers/gpu/drm/imx/imx-tve.c
+++ b/drivers/gpu/drm/imx/imx-tve.c
@@ -721,6 +721,7 @@ static const struct of_device_id imx_tve_dt_ids[] = {
{ .compatible = "fsl,imx53-tve", },
{ /* sentinel */ }
};
+MODULE_DEVICE_TABLE(of, imx_tve_dt_ids);
static struct platform_driver imx_tve_driver = {
.probe = imx_tve_probe,
--
2.5.3
Hi Luis,
thanks for the reminder.
Am Montag, den 30.11.2015, 15:02 +0000 schrieb Luis de Bethencourt:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <[email protected]>
> ---
>
> Hi,
>
> This is a resend of a patch from October 20th [0]
Sorry to have missed it, I was in the middle of a vacation then.
I've applied it to my fixes branch now.
> I am adding Andrew Morton to the CC list as was recommended at the Korea Linux
> Forum.
>
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
>
> A longer explanation by Javier Canillas can be found here:
> https://lkml.org/lkml/2015/7/30/519
> A multitude of similar patches have been merged for other drivers, search
> the git log for "module autoload for OF platform driver".
>
> Thanks,
> Luis
regards
Philipp
On 30/11/15 21:28, Philipp Zabel wrote:
> Hi Luis,
>
> thanks for the reminder.
>
No problem. I was worried I was bothering.
> Am Montag, den 30.11.2015, 15:02 +0000 schrieb Luis de Bethencourt:
>> This platform driver has a OF device ID table but the OF module
>> alias information is not created so module autoloading won't work.
>>
>> Signed-off-by: Luis de Bethencourt <[email protected]>
>> ---
>>
>> Hi,
>>
>> This is a resend of a patch from October 20th [0]
>
> Sorry to have missed it, I was in the middle of a vacation then.
> I've applied it to my fixes branch now.
>
I understand, we all have a few emails that fall between the cracks.
Thank you very much for reviewing and applying.
Luis
>> I am adding Andrew Morton to the CC list as was recommended at the Korea Linux
>> Forum.
>>
>> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
>> that information so modules have the correct aliases built-in and
>> autoloading works correctly.
>>
>> A longer explanation by Javier Canillas can be found here:
>> https://lkml.org/lkml/2015/7/30/519
>> A multitude of similar patches have been merged for other drivers, search
>> the git log for "module autoload for OF platform driver".
>>
>> Thanks,
>> Luis
>
> regards
> Philipp
>