2015-12-07 10:26:03

by Neil Armstrong

[permalink] [raw]
Subject: Re: [RFC PATCH v3 0/5] net: dsa: cleanup dsa driver

On 10/29/2015 03:45 PM, Neil Armstrong wrote:
> Introduce a new remove callback to allow DSA drivers to cleanup their
> ressources.
> Then add a remove implementation for bcm_sf2 and mv88e6xxx.
>
> This patch was not tested due of a lack of hardware.
>
> v2: add remove callback patch to the serie
> v3: separate & fix ppu remove callback into a proper patch
>
> Neil Armstrong (5):
> net: dsa: allow switch drivers to cleanup their resources
> net: dsa: bcm_sf2: cleanup resources in remove callback
> net: dsa: mv88e6xxx: add common remove function
> net: dsa: make usage of mv88e6xxx common remove function
> net: dsa: add mv88e6xxx ppu remove function for mv88e6131
>
> drivers/net/dsa/bcm_sf2.c | 20 ++++++++++++++++++++
> drivers/net/dsa/mv88e6123_61_65.c | 1 +
> drivers/net/dsa/mv88e6131.c | 8 ++++++++
> drivers/net/dsa/mv88e6171.c | 1 +
> drivers/net/dsa/mv88e6352.c | 1 +
> drivers/net/dsa/mv88e6xxx.c | 18 ++++++++++++++++++
> drivers/net/dsa/mv88e6xxx.h | 2 ++
> include/net/dsa.h | 1 +
> net/dsa/dsa.c | 4 ++++
> 9 files changed, 56 insertions(+)
>

Hi All,

Did someone had a chance to test this ?

Having such code will help for the final DSA reworking.

Neil