LinuxLists.cc - Failed to build on 4.2.6

2015-12-07 15:25:33

Subject: Failed to build on 4.2.6

Hi,

The attached config doesn't build on 4.2.6, but changing it to the
following:

VIDEO_V4L2_SUBDEV_API n -> y
+V4L2_FLASH_LED_CLASS n

does build.

Sorry, I lost the build error (currently building now with a good
config), But it's because in drivers/media/i2c/adv7604.c,
v4l2_subdev_get_try_format() is not defined.

-- Steve

Attachments:

(No filename) (331.00 B)
bad-config-4.2 (161.97 kB)
Download all attachments

2015-12-09 00:47:39

by Greg Kroah-Hartman

[permalink] [raw]

Subject: Re: Failed to build on 4.2.6

On Mon, Dec 07, 2015 at 10:25:19AM -0500, Steven Rostedt wrote:
> Hi,
>
> The attached config doesn't build on 4.2.6, but changing it to the
> following:
>
> VIDEO_V4L2_SUBDEV_API n -> y
> +V4L2_FLASH_LED_CLASS n
>
> does build.

Did this work on older kernels (4.2.5? .4? older?)

thanks,

greg k-h

2015-12-07 18:04:47

by Randy Dunlap

[permalink] [raw]

Subject: Re: Failed to build on 4.2.6

On 12/07/15 07:25, Steven Rostedt wrote:
> Hi,
>
> The attached config doesn't build on 4.2.6, but changing it to the
> following:
>
> VIDEO_V4L2_SUBDEV_API n -> y
> +V4L2_FLASH_LED_CLASS n
>
> does build.
>
> Sorry, I lost the build error (currently building now with a good
> config), But it's because in drivers/media/i2c/adv7604.c,
> v4l2_subdev_get_try_format() is not defined.
>
> -- Steve
>

4.2 stable needs this patch:

commit fc88dd16a0e430f57458e6bd9b62a631c6ea53a1
Author: Hans Verkuil <[email protected]>
Date: Mon Sep 21 08:42:04 2015 -0300

[media] cobalt: fix Kconfig dependency

The cobalt driver should depend on VIDEO_V4L2_SUBDEV_API.

===

There was also an intervening patch which may cause some editing:

commit 2f8e75d2762496bb2fcea7fa437a3339d2a6d9d4
Author: Geert Uytterhoeven <[email protected]>
Date: Mon Jun 29 10:45:56 2015 -0300

[media] adv7604/cobalt: Allow compile test if !GPIOLIB

--
~Randy

2015-12-09 10:52:04

by Luis de Bethencourt

[permalink] [raw]

Subject: Re: Failed to build on 4.2.6

Greg Kroah-Hartman writes:

> On Mon, Dec 07, 2015 at 10:25:19AM -0500, Steven Rostedt wrote:
>> Hi,
>>
>> The attached config doesn't build on 4.2.6, but changing it to the
>> following:
>>
>> VIDEO_V4L2_SUBDEV_API n -> y
>> +V4L2_FLASH_LED_CLASS n
>>
>> does build.
>
> Did this work on older kernels (4.2.5? .4? older?)
>
> thanks,
>
> greg k-h

Hi all,

The problem was:

drivers/media/i2c/adv7604.c: In function ‘adv76xx_get_format’:
drivers/media/i2c/adv7604.c:1861:3: error: implicit declaration of function ‘v4l2_subdev_get_try_format’ [-Werror=implicit-function-declaration]
fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);

As Randy mentioned, this if fixed by commit
fc88dd16a0e430f57458e6bd9b62a631c6ea53a1

I backported it locally to test this and build worked fine.

Luis