2020-06-21 00:26:27

by Valdis Klētnieks

[permalink] [raw]
Subject: opp: core: Add missing export to core.c

After this commit, a 'make allmodconfig' fails due to a missing export.
commit 5f2430fb40c74db85764c8a472ecd6849025dd3f
Author: Sibi Sankar <[email protected]>
Date: Sat Jun 6 03:03:31 2020 +0530

cpufreq: qcom: Update the bandwidth levels on frequency change

ERROR: modpost: "dev_pm_opp_adjust_voltage" [drivers/cpufreq/qcom-cpufreq-hw.ko] undefined!

Provide the export.

Fixes: 5f2430fb40c7 ("cpufreq: qcom: Update the bandwidth levels on frequency change")
Signed-off-by: Valdis Kletnieks <[email protected]>

diff --git a/drivers/opp/core.c b/drivers/opp/core.c
index 6937bf45f497..c9336aac74e9 100644
--- a/drivers/opp/core.c
+++ b/drivers/opp/core.c
@@ -2302,6 +2302,7 @@ int dev_pm_opp_adjust_voltage(struct device *dev, unsigned long freq,
dev_pm_opp_put_opp_table(opp_table);
return r;
}
+EXPORT_SYMBOL_GPL(dev_pm_opp_adjust_voltage);

/**
* dev_pm_opp_enable() - Enable a specific OPP



Attachments:
(No filename) (849.00 B)

2020-06-22 02:18:52

by Viresh Kumar

[permalink] [raw]
Subject: Re: opp: core: Add missing export to core.c

On 20-06-20, 13:03, Valdis Klētnieks wrote:
> After this commit, a 'make allmodconfig' fails due to a missing export.
> commit 5f2430fb40c74db85764c8a472ecd6849025dd3f
> Author: Sibi Sankar <[email protected]>
> Date: Sat Jun 6 03:03:31 2020 +0530
>
> cpufreq: qcom: Update the bandwidth levels on frequency change
>
> ERROR: modpost: "dev_pm_opp_adjust_voltage" [drivers/cpufreq/qcom-cpufreq-hw.ko] undefined!
>
> Provide the export.
>
> Fixes: 5f2430fb40c7 ("cpufreq: qcom: Update the bandwidth levels on frequency change")
> Signed-off-by: Valdis Kletnieks <[email protected]>
>
> diff --git a/drivers/opp/core.c b/drivers/opp/core.c
> index 6937bf45f497..c9336aac74e9 100644
> --- a/drivers/opp/core.c
> +++ b/drivers/opp/core.c
> @@ -2302,6 +2302,7 @@ int dev_pm_opp_adjust_voltage(struct device *dev, unsigned long freq,
> dev_pm_opp_put_opp_table(opp_table);
> return r;
> }
> +EXPORT_SYMBOL_GPL(dev_pm_opp_adjust_voltage);
>
> /**
> * dev_pm_opp_enable() - Enable a specific OPP
>

Applied with reworded logs.

--
viresh