2015-12-07 13:13:35

by Jisheng Zhang

Subject: [PATCH 0/2] arm: dts: berlin: fix BG2Q sdhci clk

CLKID_SDIO is used as the 2nd optional clk for all sdhci hosts in BG2Q.
We removed CLK_IGNORE_UNUSED from CLKID_SDIO's flag. These two patches
fixes this clk issue.

Jisheng Zhang (2):
ARM: dts: berlin: correct BG2Q's sdhci2 2nd clock
ARM: dts: berlin: add 2nd clock for BG2Q sdhci0 and sdhci1

arch/arm/boot/dts/berlin2q.dtsi | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

--
2.6.2

2015-12-07 13:14:00

by Jisheng Zhang

Subject: [PATCH 1/2] ARM: dts: berlin: correct BG2Q's sdhci2 2nd clock

The optional 2nd clock is CLKID_SDIO. We removed CLK_IGNORE_UNUSED
from CLKID_SDIO's flag, so the sdhci2 doesn't work. This patch fixes
this issue by correcting the sdhci2's 2nd clock.

Signed-off-by: Jisheng Zhang <[email protected]>
---
arch/arm/boot/dts/berlin2q.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
index 8ea177f..5b10129 100644
--- a/arch/arm/boot/dts/berlin2q.dtsi
+++ b/arch/arm/boot/dts/berlin2q.dtsi
@@ -135,7 +135,7 @@
compatible = "mrvl,pxav3-mmc";
reg = <0xab1000 0x200>;
interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&chip_clk CLKID_NFC_ECC>, <&chip_clk CLKID_NFC>;
+ clocks = <&chip_clk CLKID_NFC_ECC>, <&chip_clk CLKID_SDIO>;
clock-names = "io", "core";
status = "disabled";
};
--
2.6.2

2015-12-07 13:13:36

by Jisheng Zhang

Subject: [PATCH 2/2] ARM: dts: berlin: add 2nd clock for BG2Q sdhci0 and sdhci1

We removed CLK_IGNORE_UNUSED from CLKID_SDIO's flag, so the sdhci0 and
sdhci1 don't work. We fix this by adding the optional 2nd clock for
BG2Q's sdhci0 and sdhci1. This patch brings another benefit: the 2nd
clock can be disabled during runtime pm, so saves power a bit.

Signed-off-by: Jisheng Zhang <[email protected]>
---
arch/arm/boot/dts/berlin2q.dtsi | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
index 5b10129..fb1da99 100644
--- a/arch/arm/boot/dts/berlin2q.dtsi
+++ b/arch/arm/boot/dts/berlin2q.dtsi
@@ -118,7 +118,8 @@
sdhci0: sdhci@ab0000 {
compatible = "mrvl,pxav3-mmc";
reg = <0xab0000 0x200>;
- clocks = <&chip_clk CLKID_SDIO1XIN>;
+ clocks = <&chip_clk CLKID_SDIO1XIN>, <&chip_clk CLKID_SDIO>;
+ clock-names = "io", "core";
interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
status = "disabled";
};
@@ -126,7 +127,8 @@
sdhci1: sdhci@ab0800 {
compatible = "mrvl,pxav3-mmc";
reg = <0xab0800 0x200>;
- clocks = <&chip_clk CLKID_SDIO1XIN>;
+ clocks = <&chip_clk CLKID_SDIO1XIN>, <&chip_clk CLKID_SDIO>;
+ clock-names = "io", "core";
interrupts = <GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>;
status = "disabled";
};
--
2.6.2

2015-12-10 20:18:42

by Sebastian Hesselbarth

Subject: Re: [PATCH 0/2] arm: dts: berlin: fix BG2Q sdhci clk

On 07.12.2015 14:09, Jisheng Zhang wrote:
> CLKID_SDIO is used as the 2nd optional clk for all sdhci hosts in BG2Q.
> We removed CLK_IGNORE_UNUSED from CLKID_SDIO's flag. These two patches
> fixes this clk issue.
>
> Jisheng Zhang (2):
> ARM: dts: berlin: correct BG2Q's sdhci2 2nd clock
> ARM: dts: berlin: add 2nd clock for BG2Q sdhci0 and sdhci1
>
> arch/arm/boot/dts/berlin2q.dtsi | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>

Series applied to berlin/fixes.

Thanks!

Sebastian