2015-12-21 13:18:30

by Caesar Wang

[permalink] [raw]
Subject: [PATCH 1/2] ASoC: rt5616: add an of_match table

Add a device tree match table. This serves to make the driver's support
of device tree more explicit.

Signed-off-by: Caesar Wang <[email protected]>
---

sound/soc/codecs/rt5616.c | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/sound/soc/codecs/rt5616.c b/sound/soc/codecs/rt5616.c
index f4005cb..e01a32d 100644
--- a/sound/soc/codecs/rt5616.c
+++ b/sound/soc/codecs/rt5616.c
@@ -1287,6 +1287,14 @@ static const struct i2c_device_id rt5616_i2c_id[] = {
};
MODULE_DEVICE_TABLE(i2c, rt5616_i2c_id);

+#if defined(CONFIG_OF)
+static const struct of_device_id rt5616_of_match[] = {
+ { .compatible = "realtek,rt5616", },
+ {},
+};
+MODULE_DEVICE_TABLE(of, rt5616_of_match);
+#endif
+
static int rt5616_i2c_probe(struct i2c_client *i2c,
const struct i2c_device_id *id)
{
@@ -1359,6 +1367,7 @@ static void rt5616_i2c_shutdown(struct i2c_client *client)
static struct i2c_driver rt5616_i2c_driver = {
.driver = {
.name = "rt5616",
+ .of_match_table = of_match_ptr(rt5616_of_match),
},
.probe = rt5616_i2c_probe,
.remove = rt5616_i2c_remove,
--
1.9.1


2015-12-21 13:18:35

by Caesar Wang

[permalink] [raw]
Subject: [PATCH 2/2] dt-bindings: sound: add devicetree document for rt5616

Add the description for rt5616 codec.

Signed-off-by: Caesar Wang <[email protected]>
---

Documentation/devicetree/bindings/sound/rt5616.txt | 38 ++++++++++++++++++++++
1 file changed, 38 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/rt5616.txt

diff --git a/Documentation/devicetree/bindings/sound/rt5616.txt b/Documentation/devicetree/bindings/sound/rt5616.txt
new file mode 100644
index 0000000..af96207
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/rt5616.txt
@@ -0,0 +1,38 @@
+RT5616 audio CODEC
+
+This device supports I2C only.
+
+Required properties:
+
+- compatible : "realtek,rt5616".
+
+- reg : The I2C address of the device.
+
+Optional properties:
+
+Pins on the device (for linking into audio routes) for RT5616:
+
+ * IN1P
+ * IN2P
+ * IN2N
+ * LOUTL
+ * LOUTR
+ * CPN2
+ * CPP2
+ * CPN1
+ * CPP1
+ * HPO_R
+ * HPO_L
+ * ADCDAT1
+ * DACDAT1
+ * LRCK1
+ * BCLK1
+ * MCLK
+ * GPIO1
+
+Example:
+
+rt5616 {
+ compatible = "realtek,rt5616";
+ reg = <0x1b>;
+};
--
1.9.1

2015-12-21 14:11:09

by Heiko Stuebner

[permalink] [raw]
Subject: Re: [PATCH 2/2] dt-bindings: sound: add devicetree document for rt5616

Am Montag, 21. Dezember 2015, 21:18:14 schrieb Caesar Wang:
> Add the description for rt5616 codec.
>
> Signed-off-by: Caesar Wang <[email protected]>
> ---
>
> Documentation/devicetree/bindings/sound/rt5616.txt | 38
> ++++++++++++++++++++++ 1 file changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/rt5616.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/rt5616.txt
> b/Documentation/devicetree/bindings/sound/rt5616.txt new file mode 100644
> index 0000000..af96207
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/rt5616.txt
> @@ -0,0 +1,38 @@
> +RT5616 audio CODEC
> +
> +This device supports I2C only.
> +
> +Required properties:
> +
> +- compatible : "realtek,rt5616".
> +
> +- reg : The I2C address of the device.
> +
> +Optional properties:

you don't have optional properties, so that headline should probably also not
be here.


Heiko

2015-12-21 14:45:38

by Caesar Wang

[permalink] [raw]
Subject: Re: [PATCH 2/2] dt-bindings: sound: add devicetree document for rt5616



在 2015年12月21日 22:10, Heiko Stübner 写道:
> Am Montag, 21. Dezember 2015, 21:18:14 schrieb Caesar Wang:
>> Add the description for rt5616 codec.
>>
>> Signed-off-by: Caesar Wang <[email protected]>
>> ---
>>
>> Documentation/devicetree/bindings/sound/rt5616.txt | 38
>> ++++++++++++++++++++++ 1 file changed, 38 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/sound/rt5616.txt
>>
>> diff --git a/Documentation/devicetree/bindings/sound/rt5616.txt
>> b/Documentation/devicetree/bindings/sound/rt5616.txt new file mode 100644
>> index 0000000..af96207
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/rt5616.txt
>> @@ -0,0 +1,38 @@
>> +RT5616 audio CODEC
>> +
>> +This device supports I2C only.
>> +
>> +Required properties:
>> +
>> +- compatible : "realtek,rt5616".
>> +
>> +- reg : The I2C address of the device.
>> +
>> +Optional properties:
> you don't have optional properties, so that headline should probably also not
> be here.

Yep, that should remove in here. :-(

Thanks！
>
>
> Heiko
>
>
>

--
caesar wang | software engineer | [email protected]

2015-12-21 14:56:35

by Caesar Wang

[permalink] [raw]
Subject: [PATCH v1 2/2] dt-bindings: sound: add devicetree document for rt5616

Add the description for rt5616 codec.

Signed-off-by: Caesar Wang <[email protected]>

---

Changes in v1:
- As Heiko comments, remove the not exist option properties.

Documentation/devicetree/bindings/sound/rt5616.txt | 36 ++++++++++++++++++++++
1 file changed, 36 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/rt5616.txt

diff --git a/Documentation/devicetree/bindings/sound/rt5616.txt b/Documentation/devicetree/bindings/sound/rt5616.txt
new file mode 100644
index 0000000..2030a22
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/rt5616.txt
@@ -0,0 +1,36 @@
+RT5616 audio CODEC
+
+This device supports I2C only.
+
+Required properties:
+
+- compatible : "realtek,rt5616".
+
+- reg : The I2C address of the device.
+
+Pins on the device (for linking into audio routes) for RT5616:
+
+ * IN1P
+ * IN2P
+ * IN2N
+ * LOUTL
+ * LOUTR
+ * CPN2
+ * CPP2
+ * CPN1
+ * CPP1
+ * HPO_R
+ * HPO_L
+ * ADCDAT1
+ * DACDAT1
+ * LRCK1
+ * BCLK1
+ * MCLK
+ * GPIO1
+
+Example:
+
+rt5616 {
+ compatible = "realtek,rt5616";
+ reg = <0x1b>;
+};
--
1.9.1

2015-12-21 21:15:51

by Frank Rowand

[permalink] [raw]
Subject: Re: [PATCH v1 2/2] dt-bindings: sound: add devicetree document for rt5616

On 12/21/2015 6:56 AM, Caesar Wang wrote:
> Add the description for rt5616 codec.
>
> Signed-off-by: Caesar Wang <[email protected]>
>
> ---
>
> Changes in v1:
> - As Heiko comments, remove the not exist option properties.
>
> Documentation/devicetree/bindings/sound/rt5616.txt | 36 ++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/rt5616.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/rt5616.txt b/Documentation/devicetree/bindings/sound/rt5616.txt
> new file mode 100644
> index 0000000..2030a22
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/rt5616.txt
> @@ -0,0 +1,36 @@
> +RT5616 audio CODEC
> +
> +This device supports I2C only.
> +
> +Required properties:
> +
> +- compatible : "realtek,rt5616".
> +
> +- reg : The I2C address of the device.
> +
> +Pins on the device (for linking into audio routes) for RT5616:
> +
> + * IN1P
> + * IN2P
> + * IN2N
> + * LOUTL
> + * LOUTR
> + * CPN2
> + * CPP2
> + * CPN1
> + * CPP1
> + * HPO_R
> + * HPO_L
> + * ADCDAT1
> + * DACDAT1
> + * LRCK1
> + * BCLK1
> + * MCLK
> + * GPIO1
> +
> +Example:
> +
> +rt5616 {

The node name should be rt5616@1b (including the reg value
from the node).

> + compatible = "realtek,rt5616";
> + reg = <0x1b>;
> +};
>

2015-12-22 00:54:27

by Caesar Wang

[permalink] [raw]
Subject: Re: [PATCH v1 2/2] dt-bindings: sound: add devicetree document for rt5616

Hi

在 2015年12月22日 05:15, Frank Rowand 写道:
> On 12/21/2015 6:56 AM, Caesar Wang wrote:
>> Add the description for rt5616 codec.
>>
>> Signed-off-by: Caesar Wang <[email protected]>
>>
>> ---
>>
>> Changes in v1:
>> - As Heiko comments, remove the not exist option properties.
>>
>> Documentation/devicetree/bindings/sound/rt5616.txt | 36 ++++++++++++++++++++++
>> 1 file changed, 36 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/sound/rt5616.txt
>>
>> diff --git a/Documentation/devicetree/bindings/sound/rt5616.txt b/Documentation/devicetree/bindings/sound/rt5616.txt
>> new file mode 100644
>> index 0000000..2030a22
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/sound/rt5616.txt
>> @@ -0,0 +1,36 @@
>> +RT5616 audio CODEC
>> +
>> +This device supports I2C only.
>> +
>> +Required properties:
>> +
>> +- compatible : "realtek,rt5616".
>> +
>> +- reg : The I2C address of the device.
>> +
>> +Pins on the device (for linking into audio routes) for RT5616:
>> +
>> + * IN1P
>> + * IN2P
>> + * IN2N
>> + * LOUTL
>> + * LOUTR
>> + * CPN2
>> + * CPP2
>> + * CPN1
>> + * CPP1
>> + * HPO_R
>> + * HPO_L
>> + * ADCDAT1
>> + * DACDAT1
>> + * LRCK1
>> + * BCLK1
>> + * MCLK
>> + * GPIO1
>> +
>> +Example:
>> +
>> +rt5616 {
> The node name should be rt5616@1b (including the reg value
> from the node).

In general, that's right.

Okay, fixed in next version.


>
>> + compatible = "realtek,rt5616";
>> + reg = <0x1b>;
>> +};
>>
>
>
>

--
caesar wang | software engineer | [email protected]

2015-12-22 02:06:19

by Bard Liao

[permalink] [raw]
Subject: RE: [PATCH v1 2/2] dt-bindings: sound: add devicetree document for rt5616


> -----Original Message-----
> From: Caesar Wang [mailto:[email protected]]
> Sent: Monday, December 21, 2015 10:56 PM
> To: [email protected]; [email protected]
> Cc: [email protected]; [email protected];
> [email protected]; Bard Liao; [email protected]; Caesar Wang
> Subject: [PATCH v1 2/2] dt-bindings: sound: add devicetree document for
> rt5616
>
> Add the description for rt5616 codec.
>
> Signed-off-by: Caesar Wang <[email protected]>
>
> ---
>
> Changes in v1:
> - As Heiko comments, remove the not exist option properties.
>
> Documentation/devicetree/bindings/sound/rt5616.txt | 36
> ++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/sound/rt5616.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/rt5616.txt
> b/Documentation/devicetree/bindings/sound/rt5616.txt
> new file mode 100644
> index 0000000..2030a22
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/rt5616.txt
> @@ -0,0 +1,36 @@
> +RT5616 audio CODEC
> +
> +This device supports I2C only.
> +
> +Required properties:
> +
> +- compatible : "realtek,rt5616".
> +
> +- reg : The I2C address of the device.
> +
> +Pins on the device (for linking into audio routes) for RT5616:
> +
> + * IN1P
> + * IN2P
> + * IN2N
> + * LOUTL
> + * LOUTR

These names below seems not defined in rt5616_dapm_widgets.
Where are they from?

> + * CPN2
> + * CPP2
> + * CPN1
> + * CPP1
> + * HPO_R
> + * HPO_L
> + * ADCDAT1
> + * DACDAT1
> + * LRCK1
> + * BCLK1
> + * MCLK
> + * GPIO1
> +
> +Example:
> +
> +rt5616 {
> + compatible = "realtek,rt5616";
> + reg = <0x1b>;
> +};
> --
> 1.9.1