2021-05-16 08:56:18

by Tom Rix

Subject: [PATCH] f2fs: return success if there is no work to do

From: Tom Rix <[email protected]>

Static analysis reports this problem
file.c:3206:2: warning: Undefined or garbage value returned to caller
return err;
^~~~~~~~~~

err is only set if there is some work to do. Because the loop returns
immediately on an error, if all the work was done, a 0 would be returned.
Instead of checking the unlikely case that there was no work to do,
change the return of err to 0.

Signed-off-by: Tom Rix <[email protected]>
---
fs/f2fs/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index ceb575f99048c..bae0f910f5f0a 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -3203,7 +3203,7 @@ int f2fs_precache_extents(struct inode *inode)
map.m_lblk = m_next_extent;
}

- return err;
+ return 0;
}

static int f2fs_ioc_precache_extents(struct file *filp, unsigned long arg)
--
2.26.3

2021-05-17 02:10:24

by Chao Yu

Subject: Re: [f2fs-dev] [PATCH] f2fs: return success if there is no work to do

On 2021/5/16 2:09, [email protected] wrote:
> From: Tom Rix <[email protected]>
>
> Static analysis reports this problem
> file.c:3206:2: warning: Undefined or garbage value returned to caller
> return err;
> ^~~~~~~~~~
>
> err is only set if there is some work to do. Because the loop returns
> immediately on an error, if all the work was done, a 0 would be returned.
> Instead of checking the unlikely case that there was no work to do,
> change the return of err to 0.
>
> Signed-off-by: Tom Rix <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,