2015-12-02 10:15:27

by Xinwei Kong

Subject: [PATCH v4] arm64: dts: add all hi6220 i2c nodes

This patch adds all I2C nodes for the Hi6220 SoC. This hi6220 Soc
use this I2C IP of Synopsys Designware for HiKey board.

Signed-off-by: Xinwei Kong <[email protected]>
Signed-off-by: Chen Feng <[email protected]>
---
arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 34 +++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)

diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
index 82d2488..8cec56a 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
@@ -208,5 +208,39 @@
clock-names = "uartclk", "apb_pclk";
status = "disabled";
};
+
+ i2c0: i2c@f7100000 {
+ compatible = "snps,designware-i2c";
+ reg = <0x0 0xf7100000 0x0 0x1000>;
+ interrupts = <0 44 4>;
+ clocks = <&sys_ctrl HI6220_I2C0_CLK>;
+ i2c-sda-hold-time-ns = <300>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&i2c0_pmx_func &i2c0_cfg_func>;
+ status = "disabled";
+ };
+
+ i2c1: i2c@f7101000 {
+ compatible = "snps,designware-i2c";
+ reg = <0x0 0xf7101000 0x0 0x1000>;
+ clocks = <&sys_ctrl HI6220_I2C1_CLK>;
+ interrupts = <0 45 4>;
+ i2c-sda-hold-time-ns = <300>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&i2c1_pmx_func &i2c1_cfg_func>;
+ status = "disabled";
+ };
+
+ i2c2: i2c@f7102000 {
+ compatible = "snps,designware-i2c";
+ reg = <0x0 0xf7102000 0x0 0x1000>;
+ clocks = <&sys_ctrl HI6220_I2C2_CLK>;
+ interrupts = <0 46 4>;
+ i2c-sda-hold-time-ns = <300>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&i2c2_pmx_func &i2c2_cfg_func>;
+ status = "disabled";
+ };
+
};
};
--
1.9.1

2015-12-02 12:58:00

by Shawn Guo

Subject: Re: [PATCH v4] arm64: dts: add all hi6220 i2c nodes

On Wed, Dec 02, 2015 at 06:13:21PM +0800, Xinwei Kong wrote:
> This patch adds all I2C nodes for the Hi6220 SoC. This hi6220 Soc
> use this I2C IP of Synopsys Designware for HiKey board.
>
> Signed-off-by: Xinwei Kong <[email protected]>
> Signed-off-by: Chen Feng <[email protected]>

Reviewed-by: Shawn Guo <[email protected]>

2015-12-29 13:15:27

by Bintian

Subject: Re: [PATCH v4] arm64: dts: add all hi6220 i2c nodes

On 2015/12/2 18:13, Xinwei Kong wrote:
> This patch adds all I2C nodes for the Hi6220 SoC. This hi6220 Soc
> use this I2C IP of Synopsys Designware for HiKey board.
>
> Signed-off-by: Xinwei Kong <[email protected]>
> Signed-off-by: Chen Feng <[email protected]>
> ---
> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 34 +++++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index 82d2488..8cec56a 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -208,5 +208,39 @@
> clock-names = "uartclk", "apb_pclk";
> status = "disabled";
> };
> +
> + i2c0: i2c@f7100000 {
> + compatible = "snps,designware-i2c";
> + reg = <0x0 0xf7100000 0x0 0x1000>;
> + interrupts = <0 44 4>;
> + clocks = <&sys_ctrl HI6220_I2C0_CLK>;
> + i2c-sda-hold-time-ns = <300>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c0_pmx_func &i2c0_cfg_func>;
> + status = "disabled";
> + };
> +
> + i2c1: i2c@f7101000 {
> + compatible = "snps,designware-i2c";
> + reg = <0x0 0xf7101000 0x0 0x1000>;
> + clocks = <&sys_ctrl HI6220_I2C1_CLK>;
> + interrupts = <0 45 4>;
> + i2c-sda-hold-time-ns = <300>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c1_pmx_func &i2c1_cfg_func>;
> + status = "disabled";
> + };
> +
> + i2c2: i2c@f7102000 {
> + compatible = "snps,designware-i2c";
> + reg = <0x0 0xf7102000 0x0 0x1000>;
> + clocks = <&sys_ctrl HI6220_I2C2_CLK>;
> + interrupts = <0 46 4>;
> + i2c-sda-hold-time-ns = <300>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c2_pmx_func &i2c2_cfg_func>;
> + status = "disabled";
> + };
> +
> };
> };

Looks good to me!

Reviewed-by: Bintian Wang<[email protected]>

2015-12-31 01:26:50

by Xinwei Kong

Subject: Re: [PATCH v4] arm64: dts: add all hi6220 i2c nodes

+to xuwei

On 2015/12/29 21:15, Bintian wrote:
> On 2015/12/2 18:13, Xinwei Kong wrote:
>> This patch adds all I2C nodes for the Hi6220 SoC. This hi6220 Soc
>> use this I2C IP of Synopsys Designware for HiKey board.
>>
>> Signed-off-by: Xinwei Kong <[email protected]>
>> Signed-off-by: Chen Feng <[email protected]>
Reviewed-by: Shawn Guo <[email protected]>
>> ---
>> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 34 +++++++++++++++++++++++++++++++
>> 1 file changed, 34 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> index 82d2488..8cec56a 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> @@ -208,5 +208,39 @@
>> clock-names = "uartclk", "apb_pclk";
>> status = "disabled";
>> };
>> +
>> + i2c0: i2c@f7100000 {
>> + compatible = "snps,designware-i2c";
>> + reg = <0x0 0xf7100000 0x0 0x1000>;
>> + interrupts = <0 44 4>;
>> + clocks = <&sys_ctrl HI6220_I2C0_CLK>;
>> + i2c-sda-hold-time-ns = <300>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&i2c0_pmx_func &i2c0_cfg_func>;
>> + status = "disabled";
>> + };
>> +
>> + i2c1: i2c@f7101000 {
>> + compatible = "snps,designware-i2c";
>> + reg = <0x0 0xf7101000 0x0 0x1000>;
>> + clocks = <&sys_ctrl HI6220_I2C1_CLK>;
>> + interrupts = <0 45 4>;
>> + i2c-sda-hold-time-ns = <300>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&i2c1_pmx_func &i2c1_cfg_func>;
>> + status = "disabled";
>> + };
>> +
>> + i2c2: i2c@f7102000 {
>> + compatible = "snps,designware-i2c";
>> + reg = <0x0 0xf7102000 0x0 0x1000>;
>> + clocks = <&sys_ctrl HI6220_I2C2_CLK>;
>> + interrupts = <0 46 4>;
>> + i2c-sda-hold-time-ns = <300>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&i2c2_pmx_func &i2c2_cfg_func>;
>> + status = "disabled";
>> + };
>> +
>> };
>> };
>
> Looks good to me!
>
> Reviewed-by: Bintian Wang<[email protected]>
>
>
>
> .
>