2015-12-31 02:40:16

by Stephen Rothwell

Subject: linux-next: build failure after merge of the drm tree

Hi Dave,

After merging the drm tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:

ERROR: "vop_component_ops" [drivers/gpu/drm/rockchip/rockchip_vop_reg.ko] undefined!

Caused by commit

a67719d18229 ("drm/rockchip: vop: spilt register related into rockchip_reg_vop.c")

I have added the following fix patch for today (just because its
Christmas :-)):

From: Stephen Rothwell <[email protected]>
Date: Thu, 31 Dec 2015 13:35:27 +1100
Subject: [PATCH] drm/rockchip: vop: export vop_component_ops to modules

Fixes: a67719d18229 ("drm/rockchip: vop: spilt register related into rockchip_reg_vop.c")
Signed-off-by: Stephen Rothwell <[email protected]>
---
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
index d83bf87ba71e..f5b3da2f92d7 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
@@ -1395,3 +1395,4 @@ const struct component_ops vop_component_ops = {
.bind = vop_bind,
.unbind = vop_unbind,
};
+EXPORT_SYMBOL_GPL(vop_component_ops);
--
2.6.4

--
Cheers,
Stephen Rothwell [email protected]

2015-12-31 05:14:32

by Mark yao

Subject: Re: linux-next: build failure after merge of the drm tree

On 2015年12月31日 10:40, Stephen Rothwell wrote:
> Hi Dave,
>
> After merging the drm tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> ERROR: "vop_component_ops" [drivers/gpu/drm/rockchip/rockchip_vop_reg.ko] undefined!
>
> Caused by commit
>
> a67719d18229 ("drm/rockchip: vop: spilt register related into rockchip_reg_vop.c")
>
> I have added the following fix patch for today (just because its
> Christmas :-)):
>
> From: Stephen Rothwell <[email protected]>
> Date: Thu, 31 Dec 2015 13:35:27 +1100
> Subject: [PATCH] drm/rockchip: vop: export vop_component_ops to modules
>
> Fixes: a67719d18229 ("drm/rockchip: vop: spilt register related into rockchip_reg_vop.c")
> Signed-off-by: Stephen Rothwell <[email protected]>
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index d83bf87ba71e..f5b3da2f92d7 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -1395,3 +1395,4 @@ const struct component_ops vop_component_ops = {
> .bind = vop_bind,
> .unbind = vop_unbind,
> };
> +EXPORT_SYMBOL_GPL(vop_component_ops);
Hi Stephen

Thanks for the fix, Sorry for forgetting test it with modules, and

Acked-by: Mark Yao <[email protected]>

Hi Dave
Can you pick this one?


Thanks.:-)

--
Ｍark Yao