2016-03-03 03:34:47

by Caesar Wang

[permalink] [raw]
Subject: Re: [PATCH] thermal: rockchip: disable thermal->clk in err case

Hi ,

Sorry for the missing it.

在 2016年02月15日 10:27, Shawn Lin 写道:
> Disable thermal->clk when enabling pclk fails in
> resume routine.
>
> Signed-off-by: Shawn Lin <[email protected]>

Reviewed-by: Caesar Wang <[email protected]>

> ---
>
> drivers/thermal/rockchip_thermal.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
> index 9787e8a..b54f6db 100644
> --- a/drivers/thermal/rockchip_thermal.c
> +++ b/drivers/thermal/rockchip_thermal.c
> @@ -656,8 +656,10 @@ static int __maybe_unused rockchip_thermal_resume(struct device *dev)
> return error;
>
> error = clk_enable(thermal->pclk);
> - if (error)
> + if (error) {
> + clk_disable(thermal->clk);
> return error;
> + }
>
> rockchip_thermal_reset_controller(thermal->reset);
>


--
Thanks,
Caesar