2016-03-05 12:43:00

by Ingo Molnar

[permalink] [raw]
Subject: Re: [PATCH] drm/gma500: Make mdfld_dsi_connector_dpms() return a value


* Patrik Jakobsson <[email protected]> wrote:

> Hi Daniel,
>
> A patch to fix this is already merged into drm-misc:
>
> commit db9b60400f9253c25ae639797df2d0ff7a35d9d8
> Author: Sudip Mukherjee <[email protected]>
> Date: Tue Feb 2 11:35:55 2016 +0530
>
> drm/gma500: remove helper function
>
> We were getting build warning about:
> drivers/gpu/drm/gma500/mdfld_dsi_output.c:407:2: warning: initialization
> from incompatible pointer type

This should really be in drm-fixes, as this bug is now triggering an upstream
allyesconfig build failure:

drivers/gpu/drm/gma500/mdfld_dsi_output.c:407:39: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]

as we have this in Makefile:

# enforce correct pointer usage
KBUILD_CFLAGS += $(call cc-option,-Werror=incompatible-pointer-types)

Thanks,

Ingo


2016-03-05 13:54:18

by Ingo Molnar

[permalink] [raw]
Subject: Re: [PATCH] drm/gma500: Make mdfld_dsi_connector_dpms() return a value


* Ingo Molnar <[email protected]> wrote:

> as we have this in Makefile:
>
> # enforce correct pointer usage
> KBUILD_CFLAGS += $(call cc-option,-Werror=incompatible-pointer-types)

Sorry, never mind - this is a recent commit that is not upstream.

So there's no upstream build regression.

Thanks,

Ingo

2016-03-08 08:09:50

by Daniel Wagner

[permalink] [raw]
Subject: Re: [PATCH] drm/gma500: Make mdfld_dsi_connector_dpms() return a value

On 03/05/2016 02:54 PM, Ingo Molnar wrote:
>
> * Ingo Molnar <[email protected]> wrote:
>
>> as we have this in Makefile:
>>
>> # enforce correct pointer usage
>> KBUILD_CFLAGS += $(call cc-option,-Werror=incompatible-pointer-types)
>
> Sorry, never mind - this is a recent commit that is not upstream.
>
> So there's no upstream build regression.

Sorry about that. I got it wrong and didn't sent the kbuild change via
the proper tree. Still learning.