2016-03-10 10:45:41

by Shreyas B. Prabhu

[permalink] [raw]
Subject: Re: [PATCH 0/3] powerpc/powernv: Cpuidle related cleanup

Hi,
Any thoughts on this?


On 02/29/2016 05:52 PM, Shreyas B. Prabhu wrote:
> These patches are purely code movement and cleanup.
> There is no functionality change.
>
> Note, there are multiple style error reported for patch 1 and 2.
> I think this is because checkpatch script mistakes the patches
> as C code because of the presence of semi-colon in each line. I
> for now have largely ignored these errors.
>
> Shreyas B. Prabhu (3):
> powerpc/powernv: Move CHECK_HMI_INTERRUPT to exception-64s header
> powerpc/powernv: Encapsulate idle preparation steps in a macro
> powerpc/powernv: make hypervisor state restore a function
>
> arch/powerpc/include/asm/cpuidle.h | 68 ++++++++++++++
> arch/powerpc/include/asm/exception-64s.h | 19 ++++
> arch/powerpc/kernel/exceptions-64s.S | 29 +-----
> arch/powerpc/kernel/idle_power7.S | 148 ++++++++-----------------------
> 4 files changed, 129 insertions(+), 135 deletions(-)
>


2016-03-11 01:00:27

by Michael Ellerman

[permalink] [raw]
Subject: Re: [PATCH 0/3] powerpc/powernv: Cpuidle related cleanup

On Thu, 2016-03-10 at 16:15 +0530, Shreyas B Prabhu wrote:

> Hi,
> Any thoughts on this?

Haven't had time to give it a proper review yet.

Will try and get to it.

cheers