2016-03-18 05:42:51

by Dan Carpenter

[permalink] [raw]
Subject: [patch] ib_srpt: fix a WARN_ON() message

The first argument of WARN_ON() is a condition, so it means the warning
message here will just be the name without the ->qp_num information.

Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
index 1d13090..0bd3cb2 100644
--- a/drivers/infiniband/ulp/srpt/ib_srpt.c
+++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
@@ -839,7 +839,7 @@ static void srpt_zerolength_write_done(struct ib_cq *cq, struct ib_wc *wc)
if (srpt_set_ch_state(ch, CH_DISCONNECTED))
schedule_work(&ch->release_work);
else
- WARN_ONCE("%s-%d\n", ch->sess_name, ch->qp->qp_num);
+ WARN_ONCE(1, "%s-%d\n", ch->sess_name, ch->qp->qp_num);
}
}



2016-03-19 01:32:48

by Bart Van Assche

[permalink] [raw]
Subject: Re: [patch] ib_srpt: fix a WARN_ON() message

On 03/17/16 22:41, Dan Carpenter wrote:
> The first argument of WARN_ON() is a condition, so it means the warning
> message here will just be the name without the ->qp_num information.
>
> Signed-off-by: Dan Carpenter <[email protected]>
>
> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
> index 1d13090..0bd3cb2 100644
> --- a/drivers/infiniband/ulp/srpt/ib_srpt.c
> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
> @@ -839,7 +839,7 @@ static void srpt_zerolength_write_done(struct ib_cq *cq, struct ib_wc *wc)
> if (srpt_set_ch_state(ch, CH_DISCONNECTED))
> schedule_work(&ch->release_work);
> else
> - WARN_ONCE("%s-%d\n", ch->sess_name, ch->qp->qp_num);
> + WARN_ONCE(1, "%s-%d\n", ch->sess_name, ch->qp->qp_num);
> }
> }

Reviewed-by: Bart Van Assche <[email protected]>

2016-03-21 20:15:52

by Doug Ledford

[permalink] [raw]
Subject: Re: [patch] ib_srpt: fix a WARN_ON() message

On 3/18/2016 9:17 PM, Bart Van Assche wrote:
> On 03/17/16 22:41, Dan Carpenter wrote:
>> The first argument of WARN_ON() is a condition, so it means the warning
>> message here will just be the name without the ->qp_num information.
>>
>> Signed-off-by: Dan Carpenter <[email protected]>
>>
>> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c
>> b/drivers/infiniband/ulp/srpt/ib_srpt.c
>> index 1d13090..0bd3cb2 100644
>> --- a/drivers/infiniband/ulp/srpt/ib_srpt.c
>> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
>> @@ -839,7 +839,7 @@ static void srpt_zerolength_write_done(struct
>> ib_cq *cq, struct ib_wc *wc)
>> if (srpt_set_ch_state(ch, CH_DISCONNECTED))
>> schedule_work(&ch->release_work);
>> else
>> - WARN_ONCE("%s-%d\n", ch->sess_name, ch->qp->qp_num);
>> + WARN_ONCE(1, "%s-%d\n", ch->sess_name, ch->qp->qp_num);
>> }
>> }
>
> Reviewed-by: Bart Van Assche <[email protected]>

Thanks, applied.

Attachments:
signature.asc (884.00 B)
OpenPGP digital signature