On 01/28/2016 10:31 AM, Shawn Lin wrote:
> Now, no dw_mmc variant drivers use this callback, let's
> remove it.
>
> Signed-off-by: Shawn Lin <[email protected]>
> ---
>
> drivers/mmc/host/dw_mmc.c | 9 ---------
> drivers/mmc/host/dw_mmc.h | 1 -
> 2 files changed, 10 deletions(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 1d27a2b..ee13374 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -3003,15 +3003,6 @@ int dw_mci_probe(struct dw_mci *host)
> }
> }
>
> - if (drv_data && drv_data->setup_clock) {
> - ret = drv_data->setup_clock(host);
> - if (ret) {
> - dev_err(host->dev,
> - "implementation specific clock setup failed\n");
> - goto err_clk_ciu;
> - }
> - }
> -
> setup_timer(&host->cmd11_timer,
> dw_mci_cmd11_timer, (unsigned long)host);
>
> diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h
> index 1a9492e..bfc2a4d 100644
> --- a/drivers/mmc/host/dw_mmc.h
> +++ b/drivers/mmc/host/dw_mmc.h
> @@ -286,7 +286,6 @@ struct dw_mci_slot {
> struct dw_mci_drv_data {
> unsigned long *caps;
> int (*init)(struct dw_mci *host, bool setup_clk);
> - int (*setup_clock)(struct dw_mci *host);
Could you remove the description for setup_clock?
* @init: early implementation specific initialization.
- * @setup_clock: implementation specific clock configuration.
* @set_ios: handle bus specific extensions.
* @parse_dt: parse implementation specific device tree properties.
* @execute_tuning: implementation specific tuning procedure.
Best Regards,
Jaehoon Chung
> void (*prepare_command)(struct dw_mci *host, u32 *cmdr);
> void (*set_ios)(struct dw_mci *host, struct mmc_ios *ios);
> int (*parse_dt)(struct dw_mci *host);
>