2022-08-15 13:29:52

by Tony Lindgren

[permalink] [raw]
Subject: [PATCH v2 1/1] clocksource/drivers/timer-ti-dm: Fix compile test warning

We can get a warning with COMPILE_TEST enabled for omap_timer_match
for 'omap_timer_match' defined but not used.

Fixes: ab0bbef3ae0f ("clocksource/drivers/timer-ti-dm: Make timer selectable for ARCH_K3")
Reported-by: kernel test robot <[email protected]>
Suggested-by: Arnd Bergmann <[email protected]>
Signed-off-by: Tony Lindgren <[email protected]>

---

Changes since v1:

- Remove of_match_ptr() instead of adding __maybe_unused as suggested by Arnd

---
drivers/clocksource/timer-ti-dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c
--- a/drivers/clocksource/timer-ti-dm.c
+++ b/drivers/clocksource/timer-ti-dm.c
@@ -1081,7 +1081,7 @@ static struct platform_driver omap_dm_timer_driver = {
.remove = omap_dm_timer_remove,
.driver = {
.name = "omap_timer",
- .of_match_table = of_match_ptr(omap_timer_match),
+ .of_match_table = omap_timer_match,
.pm = &omap_dm_timer_pm_ops,
},
};
--
2.37.1


2022-08-15 14:33:28

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH v2 1/1] clocksource/drivers/timer-ti-dm: Fix compile test warning

On Mon, Aug 15, 2022 at 3:16 PM Tony Lindgren <[email protected]> wrote:
>
> We can get a warning with COMPILE_TEST enabled for omap_timer_match
> for 'omap_timer_match' defined but not used.
>
> Fixes: ab0bbef3ae0f ("clocksource/drivers/timer-ti-dm: Make timer selectable for ARCH_K3")
> Reported-by: kernel test robot <[email protected]>
> Suggested-by: Arnd Bergmann <[email protected]>
> Signed-off-by: Tony Lindgren <[email protected]>
>
> ---
>
> Changes since v1:
>
> - Remove of_match_ptr() instead of adding __maybe_unused as suggested by Arnd
>

Looks good to me,

Acked-by: Arnd Bergmann <[email protected]>

2022-08-17 19:12:09

by Daniel Lezcano

[permalink] [raw]
Subject: Re: [PATCH v2 1/1] clocksource/drivers/timer-ti-dm: Fix compile test warning

On 15/08/2022 15:16, Tony Lindgren wrote:
> We can get a warning with COMPILE_TEST enabled for omap_timer_match
> for 'omap_timer_match' defined but not used.
>
> Fixes: ab0bbef3ae0f ("clocksource/drivers/timer-ti-dm: Make timer selectable for ARCH_K3")
> Reported-by: kernel test robot <[email protected]>
> Suggested-by: Arnd Bergmann <[email protected]>
> Signed-off-by: Tony Lindgren <[email protected]>
>
> ---
>
> Changes since v1:
>
> - Remove of_match_ptr() instead of adding __maybe_unused as suggested by Arnd

Applied for 6.0-rc, thanks



--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog