2016-04-04 12:55:32

by Anna-Maria Behnsen

Subject: [PATCH] ARM: OMAP: wakeupgen: Add comment for unhandled FROZEN transitions

FROZEN hotplug notifiers are not handled and do not have to be. Insert
a comment to remember that the lack of the FROZEN transitions is no
accident.

Cc: Tony Lindgren <[email protected]>
Cc: Santosh Shilimkar <[email protected]>
Cc: [email protected]
Signed-off-by: Anna-Maria Gleixner <[email protected]>
---
arch/arm/mach-omap2/omap-wakeupgen.c | 5 +++++
1 file changed, 5 insertions(+)

--- a/arch/arm/mach-omap2/omap-wakeupgen.c
+++ b/arch/arm/mach-omap2/omap-wakeupgen.c
@@ -320,6 +320,11 @@ static int irq_cpu_hotplug_notify(struct
{
unsigned int cpu = (unsigned int)hcpu;

+ /*
+ * Corresponding FROZEN transitions do not have to be handled,
+ * they are handled by at a higher level
+ * (drivers/cpuidle/coupled.c).
+ */
switch (action) {
case CPU_ONLINE:
wakeupgen_irqmask_all(cpu, 0);

2016-04-04 16:06:03

by Santosh Shilimkar

Subject: Re: [PATCH] ARM: OMAP: wakeupgen: Add comment for unhandled FROZEN transitions

On 4/4/2016 5:55 AM, Anna-Maria Gleixner wrote:
> FROZEN hotplug notifiers are not handled and do not have to be. Insert
> a comment to remember that the lack of the FROZEN transitions is no
> accident.
>
> Cc: Tony Lindgren <[email protected]>
> Cc: Santosh Shilimkar <[email protected]>
> Cc: [email protected]
> Signed-off-by: Anna-Maria Gleixner <[email protected]>
> ---
Acked-by: Santosh Shilimkar <[email protected]>

2016-04-07 17:01:51

by Tony Lindgren

Subject: Re: [PATCH] ARM: OMAP: wakeupgen: Add comment for unhandled FROZEN transitions

* santosh shilimkar <[email protected]> [160404 09:06]:
> On 4/4/2016 5:55 AM, Anna-Maria Gleixner wrote:
> >FROZEN hotplug notifiers are not handled and do not have to be. Insert
> >a comment to remember that the lack of the FROZEN transitions is no
> >accident.
> >
> >Cc: Tony Lindgren <[email protected]>
> >Cc: Santosh Shilimkar <[email protected]>
> >Cc: [email protected]
> >Signed-off-by: Anna-Maria Gleixner <[email protected]>
> >---
> Acked-by: Santosh Shilimkar <[email protected]>

Yeah looks good to me too, will apply for v4.7 when I get through the
pending fixes here first.

Regards,

Tony

2016-04-13 21:32:32

by Tony Lindgren

Subject: Re: [PATCH] ARM: OMAP: wakeupgen: Add comment for unhandled FROZEN transitions

* Tony Lindgren <[email protected]> [160407 10:04]:
> * santosh shilimkar <[email protected]> [160404 09:06]:
> > On 4/4/2016 5:55 AM, Anna-Maria Gleixner wrote:
> > >FROZEN hotplug notifiers are not handled and do not have to be. Insert
> > >a comment to remember that the lack of the FROZEN transitions is no
> > >accident.
> > >
> > >Cc: Tony Lindgren <[email protected]>
> > >Cc: Santosh Shilimkar <[email protected]>
> > >Cc: [email protected]
> > >Signed-off-by: Anna-Maria Gleixner <[email protected]>
> > >---
> > Acked-by: Santosh Shilimkar <[email protected]>
>
> Yeah looks good to me too, will apply for v4.7 when I get through the
> pending fixes here first.

Applying into omap-for-v4.7/soc thanks.

Tony