2023-08-04 21:50:19

by Rafael J. Wysocki

Subject: [PATCH v4 01/10] thermal: core: Do not handle trip points with invalid temperature

From: Rafael J. Wysocki <[email protected]>

Trip points with temperature set to THERMAL_TEMP_INVALID are as good as
disabled, so make handle_thermal_trip() ignore them.

Signed-off-by: Rafael J. Wysocki <[email protected]>
---

v3 -> v4: No changes.

v2 -> v3: No changes.

v1 -> v2: No changes.

---
drivers/thermal/thermal_core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Index: linux-pm/drivers/thermal/thermal_core.c
===================================================================
--- linux-pm.orig/drivers/thermal/thermal_core.c
+++ linux-pm/drivers/thermal/thermal_core.c
@@ -348,7 +348,8 @@ static void handle_thermal_trip(struct t
struct thermal_trip trip;

/* Ignore disabled trip points */
- if (test_bit(trip_id, &tz->trips_disabled))
+ if (test_bit(trip_id, &tz->trips_disabled) ||
+ trip.temperature == THERMAL_TEMP_INVALID)
return;

__thermal_zone_get_trip(tz, trip_id, &trip);

2023-08-07 12:57:36

by Daniel Lezcano

Subject: Re: [PATCH v4 01/10] thermal: core: Do not handle trip points with invalid temperature

On 04/08/2023 23:00, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <[email protected]>
>
> Trip points with temperature set to THERMAL_TEMP_INVALID are as good as
> disabled, so make handle_thermal_trip() ignore them.
>
> Signed-off-by: Rafael J. Wysocki <[email protected]>

Acked-by: Daniel Lezcano <[email protected]>

> ---
>
> v3 -> v4: No changes.
>
> v2 -> v3: No changes.
>
> v1 -> v2: No changes.
>
> ---
> drivers/thermal/thermal_core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: linux-pm/drivers/thermal/thermal_core.c
> ===================================================================
> --- linux-pm.orig/drivers/thermal/thermal_core.c
> +++ linux-pm/drivers/thermal/thermal_core.c
> @@ -348,7 +348,8 @@ static void handle_thermal_trip(struct t
> struct thermal_trip trip;
>
> /* Ignore disabled trip points */
> - if (test_bit(trip_id, &tz->trips_disabled))
> + if (test_bit(trip_id, &tz->trips_disabled) ||
> + trip.temperature == THERMAL_TEMP_INVALID)
> return;
>
> __thermal_zone_get_trip(tz, trip_id, &trip);
>
>
>

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog