2016-04-21 18:51:59

by Javier Martinez Canillas

Subject: [PATCH] drm/exynos/hdmi: Don't print error on deferral due to regulators

The regulators may not be available just because their driver's probe
function was just not executed and so the regulators not registered.

So, in this case the Exynos HDMI driver should not print logs since
a -EPROBE_DEFER is not really an error and that will just pollute
the kernel log and confuse users.

This patch prevents the following misleading messages to be printed:

[ 1.443638] [drm:hdmi_probe] *ERROR* failed to get regulators
[ 1.449326] [drm:hdmi_probe] *ERROR* hdmi_resources_init failed

Reported-by: Krzysztof Kozlowski <[email protected]>
Signed-off-by: Javier Martinez Canillas <[email protected]>

---

The real fix for these kind of issues is to change the device model
core to support device dependencies so the number of probe deferral
should be minimal or non-existent, instead of fixing on each driver.

But there have been different attempts [0,1] to implement this and
there doesn't seem that this will be solved in the short term.

[0]: https://lkml.org/lkml/2014/5/12/452
[1]: https://lkml.org/lkml/2015/5/25/251

drivers/gpu/drm/exynos/exynos_hdmi.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
index e148d728e28c..dcac78b8aa16 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
@@ -1728,7 +1728,8 @@ static int hdmi_resources_init(struct hdmi_context *hdata)
}
ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(supply), hdata->regul_bulk);
if (ret) {
- DRM_ERROR("failed to get regulators\n");
+ if (ret != -EPROBE_DEFER)
+ DRM_ERROR("failed to get regulators\n");
return ret;
}

@@ -1852,7 +1853,8 @@ static int hdmi_probe(struct platform_device *pdev)

ret = hdmi_resources_init(hdata);
if (ret) {
- DRM_ERROR("hdmi_resources_init failed\n");
+ if (ret != -EPROBE_DEFER)
+ DRM_ERROR("hdmi_resources_init failed\n");
return ret;
}

--
2.5.5

2016-04-22 05:28:21

by Krzysztof Kozlowski

Subject: Re: [PATCH] drm/exynos/hdmi: Don't print error on deferral due to regulators

On 04/21/2016 08:51 PM, Javier Martinez Canillas wrote:
> The regulators may not be available just because their driver's probe
> function was just not executed and so the regulators not registered.
>
> So, in this case the Exynos HDMI driver should not print logs since
> a -EPROBE_DEFER is not really an error and that will just pollute
> the kernel log and confuse users.
>
> This patch prevents the following misleading messages to be printed:
>
> [ 1.443638] [drm:hdmi_probe] *ERROR* failed to get regulators
> [ 1.449326] [drm:hdmi_probe] *ERROR* hdmi_resources_init failed
>
> Reported-by: Krzysztof Kozlowski <[email protected]>
> Signed-off-by: Javier Martinez Canillas <[email protected]>
>
> ---
>
> The real fix for these kind of issues is to change the device model
> core to support device dependencies so the number of probe deferral
> should be minimal or non-existent, instead of fixing on each driver.
>
> But there have been different attempts [0,1] to implement this and
> there doesn't seem that this will be solved in the short term.
>
> [0]: https://lkml.org/lkml/2014/5/12/452
> [1]: https://lkml.org/lkml/2015/5/25/251
>
> drivers/gpu/drm/exynos/exynos_hdmi.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)

Since I like to look at 'dmesg -l err' then I find this useful:

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof