On 09.12.19 12:41, Roger Pau Monné wrote:
> On Thu, Dec 05, 2019 at 02:01:22PM +0000, Paul Durrant wrote:
>> Currently these macros will skip over any requests/responses that are
>> added to the shared ring whilst it is detached. This, in general, is not
>> a desirable semantic since most frontend implementations will eventually
>> block waiting for a response which would either never appear or never be
>> processed.
>>
>> NOTE: These macros are currently unused. BACK_RING_ATTACH(), however, will
>> be used in a subsequent patch.
>>
>> Signed-off-by: Paul Durrant <[email protected]>
>
> Those headers come from Xen, and should be modified in Xen first and
> then imported into Linux IMO.
In theory, yes. But the Xen variant doesn't contain the ATTACH macros.
Juergen
> -----Original Message-----
> From: Xen-devel <[email protected]> On Behalf Of
> Jürgen Groß
> Sent: 09 December 2019 11:52
> To: Roger Pau Monné <[email protected]>; Durrant, Paul
> <[email protected]>
> Cc: [email protected]; Boris Ostrovsky
> <[email protected]>; Stefano Stabellini <[email protected]>;
> [email protected]
> Subject: Re: [Xen-devel] [PATCH 3/4] xen/interface: don't discard pending
> work in FRONT/BACK_RING_ATTACH
>
> On 09.12.19 12:41, Roger Pau Monné wrote:
> > On Thu, Dec 05, 2019 at 02:01:22PM +0000, Paul Durrant wrote:
> >> Currently these macros will skip over any requests/responses that are
> >> added to the shared ring whilst it is detached. This, in general, is
> not
> >> a desirable semantic since most frontend implementations will
> eventually
> >> block waiting for a response which would either never appear or never
> be
> >> processed.
> >>
> >> NOTE: These macros are currently unused. BACK_RING_ATTACH(), however,
> will
> >> be used in a subsequent patch.
> >>
> >> Signed-off-by: Paul Durrant <[email protected]>
> >
> > Those headers come from Xen, and should be modified in Xen first and
> > then imported into Linux IMO.
>
> In theory, yes. But the Xen variant doesn't contain the ATTACH macros.
>
OOI do we have a policy about this? Re-importing headers into Linux wholesale is always slightly painful because of interdependencies and style checking issues.
Paul
>
> Juergen
>
> _______________________________________________
> Xen-devel mailing list
> [email protected]
> https://lists.xenproject.org/mailman/listinfo/xen-devel