On Wed, Sep 28, 2016 at 08:18:53PM +0200, Sergio Paracuellos wrote:
> This patch series fix some warnings reported by checkpatch.pl script in hfa384x.h:
> WARNING: Block comments use * on subsequent lines
> WARNING: Block comments use a trailing */ on a separate line
> WARNING: do not add new typedefs
>
> Sergio Paracuellos (87):
> staging: wlang-ng: avoid new typedef: hfa384x_bytestr32_t
> staging: wlang-ng: avoid new typedef: hfa384x_compident_t
> staging: wlang-ng: Fix block comments style warnings in hfa384x.h
> staging: wlang-ng: avoid new typedef: hfa384x_caplevel_t
> staging: wlang-ng: avoid new typedef: hfa384x_HostScanRequest_data_t
> staging: wlang-ng: avoid new typedef: hfa384x_JoinRequest_data_t
> staging: wlang-ng: avoid new typedef:
> hfa384x_authenticateStation_data_t
> staging: wlang-ng: avoid new typedef: hfa384x_WPAData_t
> staging: wlang-ng: avoid new typedef: hfa384x_downloadbuffer_t
> staging: wlang-ng: avoid new typedef: hfa384x_commsquality_t
> staging: wlang-ng: avoid new typedef: hfa384x_dbmcommsquality_t
> staging: wlang-ng: avoid new typedef: hfa384x_tx_frame_t
> staging: wlang-ng: avoid new typedef: hfa384x_rx_frame_t
> staging: wlang-ng: avoid new typedef: hfa384x_CommTallies16_t
> staging: wlang-ng: avoid new typedef: hfa384x_CommTallies32_t
> staging: wlang-ng: avoid new typedef: hfa384x_ScanResultSub_t
> staging: wlang-ng: avoid new typedef: hfa384x_ScanResult_t
> staging: wlang-ng: avoid new typedef: hfa384x_ChInfoResultSub_t
> staging: wlang-ng: avoid new typedef: hfa384x_ChInfoResult_t
> staging: wlang-ng: avoid new typedef: hfa384x_HScanResultSub_t
> staging: wlang-ng: avoid new typedef: hfa384x_HScanResult_t
> staging: wlang-ng: avoid new typedef: hfa384x_LinkStatus_t
> staging: wlang-ng: avoid new typedef: hfa384x_AssocStatus_t
> staging: wlang-ng: avoid new typedef: hfa384x_AuthReq_t
> staging: wlang-ng: avoid new typedef: hfa384x_PSUserCount_t
> staging: wlang-ng: avoid new typedef: hfa384x_KeyIDChanged_t
> staging: wlang-ng: avoid new typedef: hfa384x_infodata_t
> staging: wlang-ng: avoid new typedef: hfa384x_InfFrame_t
> staging: wlang-ng: avoid new typedef: hfa384x_usb_txfrm_t
> staging: wlang-ng: avoid new typedef: hfa384x_usb_cmdreq_t
> staging: wlang-ng: avoid new typedef: hfa384x_usb_wridreq_t
> staging: wlang-ng: avoid new typedef: hfa384x_usb_rridreq_t
> staging: wlang-ng: avoid new typedef: hfa384x_usb_wmemreq_t
> staging: wlang-ng: avoid new typedef: hfa384x_usb_rmemreq_t
> staging: wlang-ng: avoid new typedef: hfa384x_usb_rxfrm_t
> staging: wlang-ng: avoid new typedef: hfa384x_usb_infofrm_t
> staging: wlang-ng: avoid new typedef: hfa384x_usb_cmdresp_t
> staging: wlang-ng: avoid new typedef: hfa384x_usb_wridresp_t
> staging: wlang-ng: avoid new typedef: hfa384x_usb_rridresp_t
> staging: wlang-ng: avoid new typedef: hfa384x_usb_wmemresp_t
> staging: wlang-ng: avoid new typedef: hfa384x_usb_rmemresp_t
> staging: wlang-ng: avoid new typedef: hfa384x_usb_bufavail_t
> staging: wlang-ng: avoid new typedef: hfa384x_usb_error_t
> staging: wlang-ng: avoid new typedef: hfa384x_usbout_t
> staging: wlang-ng: avoid new typedef: hfa384x_usbin_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_pcb_partnum_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_pcb_tracenum_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_serial_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_mkk_measurements_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_ramsize_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_mfisuprange_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_cfisuprange_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_nicid_t
> staging: wlang-ng: avoid new typedef:
> hfa384x_pdr_refdac_measurements_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_vgdac_measurements_t
> staging: wlang-ng: avoid new typedef:
> hfa384x_pdr_level_compc_measurements_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_mac_address_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_mkk_callname_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_regdomain_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_allowed_channel_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_default_channel_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_privacy_option_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_temptype_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_refdac_setup_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_vgdac_setup_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_level_comp_setup_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_trimdac_setup_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_ifr_setting_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_rfr_setting_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_baseline_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_shadow_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_ifrf_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_chcalsp_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_chcali_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_config_t
> staging: wlang-ng: avoid new typedef: hfa384x_hfo_delay_t
> staging: wlang-ng: avoid new typedef:
> hfa384x_pdr_hfa3861_manf_testsp_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_manf_testi_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdr_end_of_pda_t
> staging: wlang-ng: avoid new typedef: hfa384x_pdrec_t
> staging: wlang-ng: avoid new typedef: hfa384x_cmdresult_t
> staging: wlang-ng: avoid new typedef: hfa384x_rridresult_t
> staging: wlang-ng: avoid new typedef: hfa384x_usbctlx_t
> staging: wlang-ng: avoid new typedef: hfa384x_usbctlxq_t
> staging: wlang-ng: avoid new typedef: hfa384x_metacmd_t
> staging: wlang-ng: avoid new typedef: hfa384x_t
> staging: wlang-ng: Fix block comments style warnings in hfa384x.h
>
> drivers/staging/wlan-ng/hfa384x.h | 874 +++++++++++++++++-----------------
> drivers/staging/wlan-ng/hfa384x_usb.c | 293 ++++++------
> drivers/staging/wlan-ng/prism2fw.c | 22 +-
> drivers/staging/wlan-ng/prism2mgmt.c | 26 +-
> drivers/staging/wlan-ng/prism2mgmt.h | 7 +-
> drivers/staging/wlan-ng/prism2mib.c | 38 +-
> drivers/staging/wlan-ng/prism2sta.c | 130 ++---
> drivers/staging/wlan-ng/prism2usb.c | 10 +-
> 8 files changed, 712 insertions(+), 688 deletions(-)
Nice work, all now applied. But next time, try not to send the whole
series twice :)
thanks,
greg k-h
El 2016年10月02日 a las 17:07, Greg KH escribió:
> On Wed, Sep 28, 2016 at 08:18:53PM +0200, Sergio Paracuellos wrote:
>> This patch series fix some warnings reported by checkpatch.pl script in hfa384x.h:
>> WARNING: Block comments use * on subsequent lines
>> WARNING: Block comments use a trailing */ on a separate line
>> WARNING: do not add new typedefs
>>
>> Sergio Paracuellos (87):
>> staging: wlang-ng: avoid new typedef: hfa384x_bytestr32_t
>> staging: wlang-ng: avoid new typedef: hfa384x_compident_t
>> staging: wlang-ng: Fix block comments style warnings in hfa384x.h
>> staging: wlang-ng: avoid new typedef: hfa384x_caplevel_t
>> staging: wlang-ng: avoid new typedef: hfa384x_HostScanRequest_data_t
>> staging: wlang-ng: avoid new typedef: hfa384x_JoinRequest_data_t
>> staging: wlang-ng: avoid new typedef:
>> hfa384x_authenticateStation_data_t
>> staging: wlang-ng: avoid new typedef: hfa384x_WPAData_t
>> staging: wlang-ng: avoid new typedef: hfa384x_downloadbuffer_t
>> staging: wlang-ng: avoid new typedef: hfa384x_commsquality_t
>> staging: wlang-ng: avoid new typedef: hfa384x_dbmcommsquality_t
>> staging: wlang-ng: avoid new typedef: hfa384x_tx_frame_t
>> staging: wlang-ng: avoid new typedef: hfa384x_rx_frame_t
>> staging: wlang-ng: avoid new typedef: hfa384x_CommTallies16_t
>> staging: wlang-ng: avoid new typedef: hfa384x_CommTallies32_t
>> staging: wlang-ng: avoid new typedef: hfa384x_ScanResultSub_t
>> staging: wlang-ng: avoid new typedef: hfa384x_ScanResult_t
>> staging: wlang-ng: avoid new typedef: hfa384x_ChInfoResultSub_t
>> staging: wlang-ng: avoid new typedef: hfa384x_ChInfoResult_t
>> staging: wlang-ng: avoid new typedef: hfa384x_HScanResultSub_t
>> staging: wlang-ng: avoid new typedef: hfa384x_HScanResult_t
>> staging: wlang-ng: avoid new typedef: hfa384x_LinkStatus_t
>> staging: wlang-ng: avoid new typedef: hfa384x_AssocStatus_t
>> staging: wlang-ng: avoid new typedef: hfa384x_AuthReq_t
>> staging: wlang-ng: avoid new typedef: hfa384x_PSUserCount_t
>> staging: wlang-ng: avoid new typedef: hfa384x_KeyIDChanged_t
>> staging: wlang-ng: avoid new typedef: hfa384x_infodata_t
>> staging: wlang-ng: avoid new typedef: hfa384x_InfFrame_t
>> staging: wlang-ng: avoid new typedef: hfa384x_usb_txfrm_t
>> staging: wlang-ng: avoid new typedef: hfa384x_usb_cmdreq_t
>> staging: wlang-ng: avoid new typedef: hfa384x_usb_wridreq_t
>> staging: wlang-ng: avoid new typedef: hfa384x_usb_rridreq_t
>> staging: wlang-ng: avoid new typedef: hfa384x_usb_wmemreq_t
>> staging: wlang-ng: avoid new typedef: hfa384x_usb_rmemreq_t
>> staging: wlang-ng: avoid new typedef: hfa384x_usb_rxfrm_t
>> staging: wlang-ng: avoid new typedef: hfa384x_usb_infofrm_t
>> staging: wlang-ng: avoid new typedef: hfa384x_usb_cmdresp_t
>> staging: wlang-ng: avoid new typedef: hfa384x_usb_wridresp_t
>> staging: wlang-ng: avoid new typedef: hfa384x_usb_rridresp_t
>> staging: wlang-ng: avoid new typedef: hfa384x_usb_wmemresp_t
>> staging: wlang-ng: avoid new typedef: hfa384x_usb_rmemresp_t
>> staging: wlang-ng: avoid new typedef: hfa384x_usb_bufavail_t
>> staging: wlang-ng: avoid new typedef: hfa384x_usb_error_t
>> staging: wlang-ng: avoid new typedef: hfa384x_usbout_t
>> staging: wlang-ng: avoid new typedef: hfa384x_usbin_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_pcb_partnum_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_pcb_tracenum_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_serial_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_mkk_measurements_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_ramsize_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_mfisuprange_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_cfisuprange_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_nicid_t
>> staging: wlang-ng: avoid new typedef:
>> hfa384x_pdr_refdac_measurements_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_vgdac_measurements_t
>> staging: wlang-ng: avoid new typedef:
>> hfa384x_pdr_level_compc_measurements_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_mac_address_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_mkk_callname_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_regdomain_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_allowed_channel_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_default_channel_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_privacy_option_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_temptype_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_refdac_setup_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_vgdac_setup_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_level_comp_setup_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_trimdac_setup_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_ifr_setting_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_rfr_setting_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_baseline_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_shadow_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_ifrf_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_chcalsp_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_chcali_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_nic_config_t
>> staging: wlang-ng: avoid new typedef: hfa384x_hfo_delay_t
>> staging: wlang-ng: avoid new typedef:
>> hfa384x_pdr_hfa3861_manf_testsp_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_hfa3861_manf_testi_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdr_end_of_pda_t
>> staging: wlang-ng: avoid new typedef: hfa384x_pdrec_t
>> staging: wlang-ng: avoid new typedef: hfa384x_cmdresult_t
>> staging: wlang-ng: avoid new typedef: hfa384x_rridresult_t
>> staging: wlang-ng: avoid new typedef: hfa384x_usbctlx_t
>> staging: wlang-ng: avoid new typedef: hfa384x_usbctlxq_t
>> staging: wlang-ng: avoid new typedef: hfa384x_metacmd_t
>> staging: wlang-ng: avoid new typedef: hfa384x_t
>> staging: wlang-ng: Fix block comments style warnings in hfa384x.h
>>
>> drivers/staging/wlan-ng/hfa384x.h | 874 +++++++++++++++++-----------------
>> drivers/staging/wlan-ng/hfa384x_usb.c | 293 ++++++------
>> drivers/staging/wlan-ng/prism2fw.c | 22 +-
>> drivers/staging/wlan-ng/prism2mgmt.c | 26 +-
>> drivers/staging/wlan-ng/prism2mgmt.h | 7 +-
>> drivers/staging/wlan-ng/prism2mib.c | 38 +-
>> drivers/staging/wlan-ng/prism2sta.c | 130 ++---
>> drivers/staging/wlan-ng/prism2usb.c | 10 +-
>> 8 files changed, 712 insertions(+), 688 deletions(-)
>
> Nice work, all now applied. But next time, try not to send the whole
> series twice :)
>
> thanks,
>
> greg k-h
>
Thanks, Greg.
I had an issue with sign-off lines in all of the patches so I fix it and
resent all of them. I'll be careful. Sorry for inconvenience.
Cheers,
Sergio Paracuellos