2024-05-01 12:55:54

by Christophe JAILLET

Subject: [PATCH] iio: light: gp2ap020a00f: Remove some unused field in struct gp2ap020a00f_data

In "struct gp2ap020a00f_data", the 'pdata' field is unused.

Moreover the "struct gp2ap020a00f_platform_data" is defined nowhere.
Neither in this file, nor in a global .h file, so it is completely
pointless.

So, remove it.

Found with cppcheck, unusedStructMember.

Signed-off-by: Christophe JAILLET <[email protected]>
---
Compile tested only.

It was added in the initial commit bf29fbeaa13d ("iio: gp2ap020a00f: Add a
driver for the device") but was never used.
---
drivers/iio/light/gp2ap020a00f.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a00f.c
index 9f41724819b6..9a476697aa1f 100644
--- a/drivers/iio/light/gp2ap020a00f.c
+++ b/drivers/iio/light/gp2ap020a00f.c
@@ -237,7 +237,6 @@ enum gp2ap020a00f_thresh_val_id {
};

struct gp2ap020a00f_data {
- const struct gp2ap020a00f_platform_data *pdata;
struct i2c_client *client;
struct mutex lock;
char *buffer;
--
2.44.0

2024-05-04 11:44:29

by Jonathan Cameron

Subject: Re: [PATCH] iio: light: gp2ap020a00f: Remove some unused field in struct gp2ap020a00f_data

On Wed, 1 May 2024 14:55:17 +0200
Christophe JAILLET <[email protected]> wrote:

> In "struct gp2ap020a00f_data", the 'pdata' field is unused.
>
> Moreover the "struct gp2ap020a00f_platform_data" is defined nowhere.
> Neither in this file, nor in a global .h file, so it is completely
> pointless.
>
> So, remove it.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <[email protected]>
Applied to the togreg branch of iio.git and pushed out as testing to let
the bots play with it.

Note I'll be rebasing that tree on rc1 once available.

Thanks,

Jonathan

> ---
> Compile tested only.
>
> It was added in the initial commit bf29fbeaa13d ("iio: gp2ap020a00f: Add a
> driver for the device") but was never used.
> ---
> drivers/iio/light/gp2ap020a00f.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a00f.c
> index 9f41724819b6..9a476697aa1f 100644
> --- a/drivers/iio/light/gp2ap020a00f.c
> +++ b/drivers/iio/light/gp2ap020a00f.c
> @@ -237,7 +237,6 @@ enum gp2ap020a00f_thresh_val_id {
> };
>
> struct gp2ap020a00f_data {
> - const struct gp2ap020a00f_platform_data *pdata;
> struct i2c_client *client;
> struct mutex lock;
> char *buffer;