2016-10-14 07:33:56

by Dan Carpenter

[permalink] [raw]
Subject: [patch] power: supply: lp8788: remove an unneeded NULL check

We checked that "pdata->chg_params" is non-NULL earlier in this function
so when we add "i" to it, it's still non-NULL.

Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/drivers/power/supply/lp8788-charger.c b/drivers/power/supply/lp8788-charger.c
index 7321b72..509e2b3 100644
--- a/drivers/power/supply/lp8788-charger.c
+++ b/drivers/power/supply/lp8788-charger.c
@@ -384,9 +384,6 @@ static int lp8788_update_charger_params(struct platform_device *pdev,
for (i = 0; i < pdata->num_chg_params; i++) {
param = pdata->chg_params + i;

- if (!param)
- continue;
-
if (lp8788_is_valid_charger_register(param->addr)) {
ret = lp8788_write_byte(lp, param->addr, param->val);
if (ret)


2016-10-17 00:45:37

by Kim, Milo

[permalink] [raw]
Subject: Re: [patch] power: supply: lp8788: remove an unneeded NULL check

On 10/14/2016 4:33 PM, Dan Carpenter wrote:
> We checked that "pdata->chg_params" is non-NULL earlier in this function
> so when we add "i" to it, it's still non-NULL.
>
> Signed-off-by: Dan Carpenter <[email protected]>

Acked-by: Milo Kim <[email protected]>

Thanks for catching this.

Best regards,
Milo

2016-10-19 03:38:11

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [patch] power: supply: lp8788: remove an unneeded NULL check

Hi Dan,

On Fri, Oct 14, 2016 at 10:33:28AM +0300, Dan Carpenter wrote:
> We checked that "pdata->chg_params" is non-NULL earlier in this function
> so when we add "i" to it, it's still non-NULL.
>
> Signed-off-by: Dan Carpenter <[email protected]>
>
> diff --git a/drivers/power/supply/lp8788-charger.c b/drivers/power/supply/lp8788-charger.c
> index 7321b72..509e2b3 100644
> --- a/drivers/power/supply/lp8788-charger.c
> +++ b/drivers/power/supply/lp8788-charger.c
> @@ -384,9 +384,6 @@ static int lp8788_update_charger_params(struct platform_device *pdev,
> for (i = 0; i < pdata->num_chg_params; i++) {
> param = pdata->chg_params + i;
>
> - if (!param)
> - continue;
> -
> if (lp8788_is_valid_charger_register(param->addr)) {
> ret = lp8788_write_byte(lp, param->addr, param->val);
> if (ret)

Thanks, queued.

-- Sebastian

Attachments:
(No filename) (860.00 B)
 signature.asc (801.00 B)
 Download all attachments