2012-05-01 04:55:40

by Benjamin Herrenschmidt

Subject: Re: linux-next: build failure after merge of the kvm-ppc tree

On Tue, 2012-05-01 at 13:55 +1000, Stephen Rothwell wrote:
> After merging the kvm-ppc tree, today's linux-next build
> (powerpc_ppc64_defconfig) failed like this:
>
> arch/powerpc/kvm/built-in.o: In function `.kvm_spapr_tce_release':
> book3s_64_vio.c:(.text+0x374c): undefined reference to `.kvm_put_kvm'
> arch/powerpc/kvm/built-in.o: In function
> `.kvm_vm_ioctl_create_spapr_tce':
> (.text+0x3ae8): undefined reference to `.kvm_get_kvm'
>
> Presumably caused by commit 969f70395d6d ("kvm/book3s: Make kernel
> emulated H_PUT_TCE available for "PR" KVM").
>
> I have used the kvm-ppc tree from next-20120430 for today.

Hrm, I wrote that patch :-) It used to work... Alex, probably just a
missing #include no ?

Cheers,
Ben.

2012-05-01 08:35:49

by Alexander Graf

Subject: Re: linux-next: build failure after merge of the kvm-ppc tree

On 01.05.2012, at 06:55, Benjamin Herrenschmidt <[email protected]> wrote:

> On Tue, 2012-05-01 at 13:55 +1000, Stephen Rothwell wrote:
>> After merging the kvm-ppc tree, today's linux-next build
>> (powerpc_ppc64_defconfig) failed like this:
>>
>> arch/powerpc/kvm/built-in.o: In function `.kvm_spapr_tce_release':
>> book3s_64_vio.c:(.text+0x374c): undefined reference to `.kvm_put_kvm'
>> arch/powerpc/kvm/built-in.o: In function
>> `.kvm_vm_ioctl_create_spapr_tce':
>> (.text+0x3ae8): undefined reference to `.kvm_get_kvm'
>>
>> Presumably caused by commit 969f70395d6d ("kvm/book3s: Make kernel
>> emulated H_PUT_TCE available for "PR" KVM").
>>
>> I have used the kvm-ppc tree from next-20120430 for today.
>
> Hrm, I wrote that patch :-) It used to work... Alex, probably just a
> missing #include no ?

Well, in fact it even compiled just fine for me with my config.

Ben, I'm out today (labor day). Could you please try make defconfog and check why it fails?

Alex