2023-11-27 01:04:49

by Yang Li

[permalink] [raw]
Subject: [PATCH -next] drm/imagination: Remove unneeded semicolon

./drivers/gpu/drm/imagination/pvr_free_list.c:258:2-3: Unneeded semicolon

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7635
Signed-off-by: Yang Li <[email protected]>
---
drivers/gpu/drm/imagination/pvr_free_list.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/imagination/pvr_free_list.c b/drivers/gpu/drm/imagination/pvr_free_list.c
index c61fd417edcb..5e51bc980751 100644
--- a/drivers/gpu/drm/imagination/pvr_free_list.c
+++ b/drivers/gpu/drm/imagination/pvr_free_list.c
@@ -255,7 +255,7 @@ pvr_free_list_insert_pages_locked(struct pvr_free_list *free_list,

if (!num_pages)
break;
- };
+ }
/* clang-format on */

/* Make sure our free_list update is flushed. */
--
2.20.1.7.g153144c


2023-11-27 10:46:22

by Frank Binns

[permalink] [raw]
Subject: Re: [PATCH -next] drm/imagination: Remove unneeded semicolon

Hi,

Thank you for the patch.

On Mon, 2023-11-27 at 09:04 +0800, Yang Li wrote:
> ./drivers/gpu/drm/imagination/pvr_free_list.c:258:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7635
> Signed-off-by: Yang Li <[email protected]>

Reviewed-by: Frank Binns <[email protected]>

> ---
> drivers/gpu/drm/imagination/pvr_free_list.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/imagination/pvr_free_list.c b/drivers/gpu/drm/imagination/pvr_free_list.c
> index c61fd417edcb..5e51bc980751 100644
> --- a/drivers/gpu/drm/imagination/pvr_free_list.c
> +++ b/drivers/gpu/drm/imagination/pvr_free_list.c
> @@ -255,7 +255,7 @@ pvr_free_list_insert_pages_locked(struct pvr_free_list *free_list,
>
> if (!num_pages)
> break;
> - };
> + }
> /* clang-format on */
>
> /* Make sure our free_list update is flushed. */

2023-11-28 13:01:36

by Maxime Ripard

[permalink] [raw]
Subject: Re: (subset) [PATCH -next] drm/imagination: Remove unneeded semicolon

On Mon, 27 Nov 2023 09:04:30 +0800, Yang Li wrote:
> ./drivers/gpu/drm/imagination/pvr_free_list.c:258:2-3: Unneeded semicolon
>
>

Applied to drm/drm-misc (drm-misc-next).

Thanks!
Maxime