The Message Signaled Interrupts (MSI) has been introduced
to UFS driver since the MCQ be enabled. Hence in UFS DT
node we need to give the msi-parent property that point
to the hardware entity which serves as the MSI controller
for this UFS controller.
Signed-off-by: Ziqi Chen <[email protected]>
---
Documentation/devicetree/bindings/ufs/ufs-common.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/ufs/ufs-common.yaml b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
index bbaee4f5..42309bb 100644
--- a/Documentation/devicetree/bindings/ufs/ufs-common.yaml
+++ b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
@@ -73,6 +73,8 @@ properties:
description:
Specifies max. load that can be drawn from VCCQ2 supply.
+ msi-parent: true
+
dependencies:
freq-table-hz: [ clocks ]
--
2.7.4
On Wed, Nov 01, 2023 at 06:48:13PM +0800, Ziqi Chen wrote:
> The Message Signaled Interrupts (MSI) has been introduced
> to UFS driver since the MCQ be enabled.
Not really relevant when a driver supported MSI, but the when the h/w
did. Has UFS always supported MSI? It was added in some version of the
spec?
> Hence in UFS DT
> node we need to give the msi-parent property that point
> to the hardware entity which serves as the MSI controller
> for this UFS controller.
>
> Signed-off-by: Ziqi Chen <[email protected]>
> ---
> Documentation/devicetree/bindings/ufs/ufs-common.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ufs/ufs-common.yaml b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
> index bbaee4f5..42309bb 100644
> --- a/Documentation/devicetree/bindings/ufs/ufs-common.yaml
> +++ b/Documentation/devicetree/bindings/ufs/ufs-common.yaml
> @@ -73,6 +73,8 @@ properties:
> description:
> Specifies max. load that can be drawn from VCCQ2 supply.
>
> + msi-parent: true
> +
> dependencies:
> freq-table-hz: [ clocks ]
>
> --
> 2.7.4
>
On 11/6/23 06:48, Rob Herring wrote:
> On Wed, Nov 01, 2023 at 06:48:13PM +0800, Ziqi Chen wrote:
>> The Message Signaled Interrupts (MSI) has been introduced
>> to UFS driver since the MCQ be enabled.
>
> Not really relevant when a driver supported MSI, but the when the h/w
> did. Has UFS always supported MSI? It was added in some version of the
> spec?
MSI support has been introduced in UFSHCI version 4.0 and I think that
the controller vendor can decide whether or not to implement MSI. Does
this mean that the patch needs to be improved?
Thanks,
Bart.
On 01/11/2023 11:48, Ziqi Chen wrote:
> The Message Signaled Interrupts (MSI) has been introduced
> to UFS driver since the MCQ be enabled. Hence in UFS DT
> node we need to give the msi-parent property that point
> to the hardware entity which serves as the MSI controller
> for this UFS controller.
>
> Signed-off-by: Ziqi Chen <[email protected]>
Which tree or next did you use as base for this patch? It does not
apply, neither on October's next nor on current. It does not apply on
v6.7-rc1 either...
Best regards,
Krzysztof