2022-04-12 21:20:33

by Stanimir Varbanov

[permalink] [raw]
Subject: Re: [PATCH 2/2] media: venus: vdec: ensure venus is powered on during stream off

Hi Vikash,

On 4/12/22 10:09, Vikash Garodia wrote:
> Video decoder driver auto-suspends the hardware if there is no
> exchange of command or response for certain amount of time.
> In auto suspended state, it becomes mandatory to power on the
> hardware before requesting it to process a command. The fix
> ensures the hardware is powered on during stop streaming.
> ---
> drivers/media/platform/qcom/venus/vdec.c | 2 ++
> 1 file changed, 2 insertions(+)

Acked-by: Stanimir Varbanov <[email protected]>

>
> diff --git a/drivers/media/platform/qcom/venus/vdec.c b/drivers/media/platform/qcom/venus/vdec.c
> index 91da3f5..4ac1132 100644
> --- a/drivers/media/platform/qcom/venus/vdec.c
> +++ b/drivers/media/platform/qcom/venus/vdec.c
> @@ -1200,6 +1200,8 @@ static void vdec_stop_streaming(struct vb2_queue *q)
> struct venus_inst *inst = vb2_get_drv_priv(q);
> int ret = -EINVAL;
>
> + vdec_pm_get_put(inst);
> +
> mutex_lock(&inst->lock);
>
> if (q->type == V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE)

--
regards,
Stan