2017-04-13 20:57:49

by Fengguang Wu

[permalink] [raw]
Subject: [PATCH] regulator: tps65132: fix platform_no_drv_owner.cocci warnings

drivers/regulator/tps65132-regulator.c:274:3-8: No need to set .owner here. The core will do it.

Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

CC: Venkat Reddy Talla <[email protected]>
Signed-off-by: Fengguang Wu <[email protected]>
---

tps65132-regulator.c | 1 -
1 file changed, 1 deletion(-)

--- a/drivers/regulator/tps65132-regulator.c
+++ b/drivers/regulator/tps65132-regulator.c
@@ -271,7 +271,6 @@ MODULE_DEVICE_TABLE(i2c, tps65132_id);
static struct i2c_driver tps65132_i2c_driver = {
.driver = {
.name = "tps65132",
- .owner = THIS_MODULE,
},
.probe = tps65132_probe,
.id_table = tps65132_id,


2017-04-14 09:05:50

by Laxman Dewangan

[permalink] [raw]
Subject: Re: [PATCH] regulator: tps65132: fix platform_no_drv_owner.cocci warnings


On Friday 14 April 2017 02:27 AM, kbuild test robot wrote:
> drivers/regulator/tps65132-regulator.c:274:3-8: No need to set .owner here. The core will do it.
>
> Remove .owner field if calls are used which set it automatically
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> CC: Venkat Reddy Talla <[email protected]>
> Signed-off-by: Fengguang Wu <[email protected]>
> ---
LGTM,
Acked-by: Laxman Dewangan <[email protected]>

2017-04-14 17:12:50

by Mark Brown

[permalink] [raw]
Subject: Applied "regulator: tps65132: fix platform_no_drv_owner.cocci warnings" to the regulator tree

The patch

regulator: tps65132: fix platform_no_drv_owner.cocci warnings

has been applied to the regulator tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 43594dd453f082d36336ea8338cd9c2d28c1691a Mon Sep 17 00:00:00 2001
From: kbuild test robot <[email protected]>
Date: Fri, 14 Apr 2017 04:57:35 +0800
Subject: [PATCH] regulator: tps65132: fix platform_no_drv_owner.cocci warnings

drivers/regulator/tps65132-regulator.c:274:3-8: No need to set .owner here. The core will do it.

Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Signed-off-by: Fengguang Wu <[email protected]>
Acked-by: Laxman Dewangan <[email protected]>
Signed-off-by: Mark Brown <[email protected]>
---
drivers/regulator/tps65132-regulator.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/regulator/tps65132-regulator.c b/drivers/regulator/tps65132-regulator.c
index a2fc7322f434..73978dd440f7 100644
--- a/drivers/regulator/tps65132-regulator.c
+++ b/drivers/regulator/tps65132-regulator.c
@@ -271,7 +271,6 @@ MODULE_DEVICE_TABLE(i2c, tps65132_id);
static struct i2c_driver tps65132_i2c_driver = {
.driver = {
.name = "tps65132",
- .owner = THIS_MODULE,
},
.probe = tps65132_probe,
.id_table = tps65132_id,
--
2.11.0