2019-11-22 15:50:00

by Colin King

Subject: [PATCH] IB/hfi1: remove redundant assignment to variable ret

From: Colin Ian King <[email protected]>

The variable ret is being initialized with a value that is never
read and it is being updated later with a new value. The
initialization is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/infiniband/hw/hfi1/platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/hfi1/platform.c b/drivers/infiniband/hw/hfi1/platform.c
index cbf7faa5038c..36593f2efe26 100644
--- a/drivers/infiniband/hw/hfi1/platform.c
+++ b/drivers/infiniband/hw/hfi1/platform.c
@@ -634,7 +634,7 @@ static void apply_tx_lanes(struct hfi1_pportdata *ppd, u8 field_id,
u32 config_data, const char *message)
{
u8 i;
- int ret = HCMD_SUCCESS;
+ int ret;

for (i = 0; i < 4; i++) {
ret = load_8051_config(ppd->dd, field_id, i, config_data);
--
2.24.0

2019-11-22 17:59:22

by Dennis Dalessandro

Subject: Re: [PATCH] IB/hfi1: remove redundant assignment to variable ret

On 11/22/2019 10:48 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The variable ret is being initialized with a value that is never
> read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/infiniband/hw/hfi1/platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/hfi1/platform.c b/drivers/infiniband/hw/hfi1/platform.c
> index cbf7faa5038c..36593f2efe26 100644
> --- a/drivers/infiniband/hw/hfi1/platform.c
> +++ b/drivers/infiniband/hw/hfi1/platform.c
> @@ -634,7 +634,7 @@ static void apply_tx_lanes(struct hfi1_pportdata *ppd, u8 field_id,
> u32 config_data, const char *message)
> {
> u8 i;
> - int ret = HCMD_SUCCESS;
> + int ret;
>
> for (i = 0; i < 4; i++) {
> ret = load_8051_config(ppd->dd, field_id, i, config_data);
>

Thanks.

Acked-by: Dennis Dalessandro <[email protected]>

2019-11-22 20:28:34

by Jason Gunthorpe

Subject: Re: [PATCH] IB/hfi1: remove redundant assignment to variable ret

On Fri, Nov 22, 2019 at 03:48:14PM +0000, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The variable ret is being initialized with a value that is never
> read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>
> Acked-by: Dennis Dalessandro <[email protected]>
> ---
> drivers/infiniband/hw/hfi1/platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-next, thanks

Jason