2021-06-03 12:37:31

by Colin King

Subject: [PATCH] drm/amdgpu: remove redundant assignment of variable k

From: Colin Ian King <[email protected]>

The variable k is being assigned a value that is never read, the
assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
index 2a7bed66d50b..f545dc1248b8 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
@@ -278,7 +278,7 @@ static int amdgpu_amdkfd_remove_eviction_fence(struct amdgpu_bo *bo,
write_seqcount_end(&resv->seq);

/* Drop the references to the removed fences or move them to ef_list */
- for (i = j, k = 0; i < old->shared_count; ++i) {
+ for (i = j; i < old->shared_count; ++i) {
struct dma_fence *f;

f = rcu_dereference_protected(new->shared[i],
--
2.31.1

2021-06-03 15:24:22

by Felix Kuehling

Subject: Re: [PATCH] drm/amdgpu: remove redundant assignment of variable k

Am 2021-06-03 um 8:34 a.m. schrieb Colin King:
> From: Colin Ian King <[email protected]>
>
> The variable k is being assigned a value that is never read, the
> assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>

Reviewed-by: Felix Kuehling <[email protected]>

I'm applying the patch to amd-staging-drm-next.

Thanks,
  Felix


> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> index 2a7bed66d50b..f545dc1248b8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> @@ -278,7 +278,7 @@ static int amdgpu_amdkfd_remove_eviction_fence(struct amdgpu_bo *bo,
> write_seqcount_end(&resv->seq);
>
> /* Drop the references to the removed fences or move them to ef_list */
> - for (i = j, k = 0; i < old->shared_count; ++i) {
> + for (i = j; i < old->shared_count; ++i) {
> struct dma_fence *f;
>
> f = rcu_dereference_protected(new->shared[i],

2021-06-04 07:58:51

by Christian König

Subject: Re: [PATCH] drm/amdgpu: remove redundant assignment of variable k

Am 03.06.21 um 14:34 schrieb Colin King:
> From: Colin Ian King <[email protected]>
>
> The variable k is being assigned a value that is never read, the
> assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>

Reviewed-by: Christian König <[email protected]>

> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> index 2a7bed66d50b..f545dc1248b8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
> @@ -278,7 +278,7 @@ static int amdgpu_amdkfd_remove_eviction_fence(struct amdgpu_bo *bo,
> write_seqcount_end(&resv->seq);
>
> /* Drop the references to the removed fences or move them to ef_list */
> - for (i = j, k = 0; i < old->shared_count; ++i) {
> + for (i = j; i < old->shared_count; ++i) {
> struct dma_fence *f;
>
> f = rcu_dereference_protected(new->shared[i],