2020-02-04 00:38:34

by Crystal Wood

[permalink] [raw]
Subject: [PATCH] sched/core: sched_tick_remote: Remove duplicate assignment

A redundant "curr = rq->curr" was added; remove it.

Fixes: ebc0f83c78a2 ("timers/nohz: Update NOHZ load in remote tick")
Signed-off-by: Scott Wood <[email protected]>
---
kernel/sched/core.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 45f79bcc3146..377ec26e9159 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3683,7 +3683,6 @@ static void sched_tick_remote(struct work_struct *work)
if (cpu_is_offline(cpu))
goto out_unlock;

- curr = rq->curr;
update_rq_clock(rq);

if (!is_idle_task(curr)) {
--
1.8.3.1


2020-02-04 14:28:52

by Phil Auld

[permalink] [raw]
Subject: Re: [PATCH] sched/core: sched_tick_remote: Remove duplicate assignment

Hi Scott,

On Mon, Feb 03, 2020 at 07:35:58PM -0500 Scott Wood wrote:
> A redundant "curr = rq->curr" was added; remove it.
>
> Fixes: ebc0f83c78a2 ("timers/nohz: Update NOHZ load in remote tick")
> Signed-off-by: Scott Wood <[email protected]>
> ---
> kernel/sched/core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 45f79bcc3146..377ec26e9159 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -3683,7 +3683,6 @@ static void sched_tick_remote(struct work_struct *work)
> if (cpu_is_offline(cpu))
> goto out_unlock;
>
> - curr = rq->curr;
> update_rq_clock(rq);
>
> if (!is_idle_task(curr)) {
> --
> 1.8.3.1
>

Reviewed-by: Phil Auld <[email protected]>

Out of curiosity, why remove this one and not the one right before the
cpu_is_offline check?


Cheers,
Phil

--

2020-02-04 17:03:41

by Crystal Wood

[permalink] [raw]
Subject: Re: [PATCH] sched/core: sched_tick_remote: Remove duplicate assignment

On Tue, 2020-02-04 at 09:27 -0500, Phil Auld wrote:
> Hi Scott,
>
> On Mon, Feb 03, 2020 at 07:35:58PM -0500 Scott Wood wrote:
> > A redundant "curr = rq->curr" was added; remove it.
> >
> > Fixes: ebc0f83c78a2 ("timers/nohz: Update NOHZ load in remote tick")
> > Signed-off-by: Scott Wood <[email protected]>
> > ---
> > kernel/sched/core.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> > index 45f79bcc3146..377ec26e9159 100644
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -3683,7 +3683,6 @@ static void sched_tick_remote(struct work_struct
> > *work)
> > if (cpu_is_offline(cpu))
> > goto out_unlock;
> >
> > - curr = rq->curr;
> > update_rq_clock(rq);
> >
> > if (!is_idle_task(curr)) {
> > --
> > 1.8.3.1
> >
>
> Reviewed-by: Phil Auld <[email protected]>
>
> Out of curiosity, why remove this one and not the one right before the
> cpu_is_offline check?

This was the one that was recently added by mistake.

-Scott


2020-02-11 12:50:04

by tip-bot2 for Jacob Pan

[permalink] [raw]
Subject: [tip: sched/core] sched/core: Remove duplicate assignment in sched_tick_remote()

The following commit has been merged into the sched/core branch of tip:

Commit-ID: 4ccfaab0853bfea772558db6a5e289e87cba57ed
Gitweb: https://git.kernel.org/tip/4ccfaab0853bfea772558db6a5e289e87cba57ed
Author: Scott Wood <[email protected]>
AuthorDate: Mon, 03 Feb 2020 19:35:58 -05:00
Committer: Ingo Molnar <[email protected]>
CommitterDate: Tue, 11 Feb 2020 12:59:22 +01:00

sched/core: Remove duplicate assignment in sched_tick_remote()

A redundant "curr = rq->curr" was added; remove it.

Fixes: ebc0f83c78a2 ("timers/nohz: Update NOHZ load in remote tick")
Signed-off-by: Scott Wood <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
---
kernel/sched/core.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 45f79bc..377ec26 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3683,7 +3683,6 @@ static void sched_tick_remote(struct work_struct *work)
if (cpu_is_offline(cpu))
goto out_unlock;

- curr = rq->curr;
update_rq_clock(rq);

if (!is_idle_task(curr)) {

2020-02-20 20:11:13

by tip-bot2 for Jacob Pan

[permalink] [raw]
Subject: [tip: sched/core] sched/core: Remove duplicate assignment in sched_tick_remote()

The following commit has been merged into the sched/core branch of tip:

Commit-ID: 82e0516ce3a147365a5dd2a9bedd5ba43a18663d
Gitweb: https://git.kernel.org/tip/82e0516ce3a147365a5dd2a9bedd5ba43a18663d
Author: Scott Wood <[email protected]>
AuthorDate: Mon, 03 Feb 2020 19:35:58 -05:00
Committer: Thomas Gleixner <[email protected]>
CommitterDate: Thu, 20 Feb 2020 21:03:13 +01:00

sched/core: Remove duplicate assignment in sched_tick_remote()

A redundant "curr = rq->curr" was added; remove it.

Fixes: ebc0f83c78a2 ("timers/nohz: Update NOHZ load in remote tick")
Signed-off-by: Scott Wood <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]

---
kernel/sched/core.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 45f79bc..377ec26 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -3683,7 +3683,6 @@ static void sched_tick_remote(struct work_struct *work)
if (cpu_is_offline(cpu))
goto out_unlock;

- curr = rq->curr;
update_rq_clock(rq);

if (!is_idle_task(curr)) {