f2fs and xfs have both added support for cgroup writeback:
578c647 f2fs: implement cgroup writeback support
adfb5fb xfs: implement cgroup aware writeback
so add them to the supported list in the docs.
Signed-off-by: Eric Sandeen <[email protected]>
---
TBH I wonder about the wisdom of having this detail in
the doc, as it apparently gets missed quite often ...
diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
index ce3e05e..4f82afa 100644
--- a/Documentation/admin-guide/cgroup-v2.rst
+++ b/Documentation/admin-guide/cgroup-v2.rst
@@ -1684,9 +1684,9 @@ per-cgroup dirty memory states are examined and the more restrictive
of the two is enforced.
cgroup writeback requires explicit support from the underlying
-filesystem. Currently, cgroup writeback is implemented on ext2, ext4
-and btrfs. On other filesystems, all writeback IOs are attributed to
-the root cgroup.
+filesystem. Currently, cgroup writeback is implemented on ext2, ext4,
+btrfs, f2fs, and xfs. On other filesystems, all writeback IOs are
+attributed to the root cgroup.
There are inherent differences in memory and writeback management
which affects how cgroup ownership is tracked. Memory is tracked per
On 2020/6/30 3:08, Eric Sandeen wrote:
> f2fs and xfs have both added support for cgroup writeback:
>
> 578c647 f2fs: implement cgroup writeback support
> adfb5fb xfs: implement cgroup aware writeback
>
> so add them to the supported list in the docs.
Thanks for the fix.
>
> Signed-off-by: Eric Sandeen <[email protected]>
Acked-by: Chao Yu <[email protected]>
Thanks,
On Mon, Jun 29, 2020 at 02:08:09PM -0500, Eric Sandeen wrote:
> f2fs and xfs have both added support for cgroup writeback:
>
> 578c647 f2fs: implement cgroup writeback support
> adfb5fb xfs: implement cgroup aware writeback
>
> so add them to the supported list in the docs.
>
> Signed-off-by: Eric Sandeen <[email protected]>
> ---
>
> TBH I wonder about the wisdom of having this detail in
> the doc, as it apparently gets missed quite often ...
I'd rather remove the list of file systems. It has no chance of
staying uptodate.
On 6/30/20 12:42 AM, Christoph Hellwig wrote:
> On Mon, Jun 29, 2020 at 02:08:09PM -0500, Eric Sandeen wrote:
>> f2fs and xfs have both added support for cgroup writeback:
>>
>> 578c647 f2fs: implement cgroup writeback support
>> adfb5fb xfs: implement cgroup aware writeback
>>
>> so add them to the supported list in the docs.
>>
>> Signed-off-by: Eric Sandeen <[email protected]>
>> ---
>>
>> TBH I wonder about the wisdom of having this detail in
>> the doc, as it apparently gets missed quite often ...
>
> I'd rather remove the list of file systems. It has no chance of
> staying uptodate.
Is there any way for a user to know whether a filesytem does or doesn't
support it, in practice?
Thanks,
-Eric
On Tue, Jun 30, 2020 at 08:59:34AM -0500, Eric Sandeen wrote:
> On 6/30/20 12:42 AM, Christoph Hellwig wrote:
> > On Mon, Jun 29, 2020 at 02:08:09PM -0500, Eric Sandeen wrote:
> >> f2fs and xfs have both added support for cgroup writeback:
> >>
> >> 578c647 f2fs: implement cgroup writeback support
> >> adfb5fb xfs: implement cgroup aware writeback
> >>
> >> so add them to the supported list in the docs.
> >>
> >> Signed-off-by: Eric Sandeen <[email protected]>
> >> ---
> >>
> >> TBH I wonder about the wisdom of having this detail in
> >> the doc, as it apparently gets missed quite often ...
> >
> > I'd rather remove the list of file systems. It has no chance of
> > staying uptodate.
>
> Is there any way for a user to know whether a filesytem does or doesn't
> support it, in practice?
git-grep SB_I_CGROUPWB
On 7/1/20 3:32 AM, Christoph Hellwig wrote:
> On Tue, Jun 30, 2020 at 08:59:34AM -0500, Eric Sandeen wrote:
>> On 6/30/20 12:42 AM, Christoph Hellwig wrote:
>>> On Mon, Jun 29, 2020 at 02:08:09PM -0500, Eric Sandeen wrote:
>>>> f2fs and xfs have both added support for cgroup writeback:
>>>>
>>>> 578c647 f2fs: implement cgroup writeback support
>>>> adfb5fb xfs: implement cgroup aware writeback
>>>>
>>>> so add them to the supported list in the docs.
>>>>
>>>> Signed-off-by: Eric Sandeen <[email protected]>
>>>> ---
>>>>
>>>> TBH I wonder about the wisdom of having this detail in
>>>> the doc, as it apparently gets missed quite often ...
>>>
>>> I'd rather remove the list of file systems. It has no chance of
>>> staying uptodate.
>>
>> Is there any way for a user to know whether a filesytem does or doesn't
>> support it, in practice?
>
> git-grep SB_I_CGROUPWB
Sure, but that's not quite what I meant by "a user" :) So I'll take that
as a no.
Thanks,
-Eric
On Mon, 29 Jun 2020 14:08:09 -0500
Eric Sandeen <[email protected]> wrote:
> f2fs and xfs have both added support for cgroup writeback:
>
> 578c647 f2fs: implement cgroup writeback support
> adfb5fb xfs: implement cgroup aware writeback
>
> so add them to the supported list in the docs.
>
> Signed-off-by: Eric Sandeen <[email protected]>
> ---
>
> TBH I wonder about the wisdom of having this detail in
> the doc, as it apparently gets missed quite often ...
Good question, but as long as it's there it might as well be correct;
applied, thanks.
jon