2024-01-11 16:22:57

by POPESCU Catalin

[permalink] [raw]
Subject: [PATCH 2/3] dt-bindings: net: dp83826: add ti,cfg-dac-plus binding

Add property ti,cfg-dac-plus to allow for voltage tuning
of logical level +1 of the MLT-3 encoded data.

Signed-off-by: Catalin Popescu <[email protected]>
---
Documentation/devicetree/bindings/net/ti,dp83822.yaml | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/ti,dp83822.yaml b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
index 2f010333be49..f9b68bde57a4 100644
--- a/Documentation/devicetree/bindings/net/ti,dp83822.yaml
+++ b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
@@ -71,6 +71,15 @@ properties:
13 = 131.25%, 14 = 137.50%, 15 = 143.75%, 16 = 150%.
enum: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16]

+ ti,cfg-dac-plus:
+ description: |
+ DP83826 PHY only.
+ Sets the voltage ratio of the logical level +1 for the MLT-3 encoded data.
+ 0 = 50%, 1 = 56.25%, 2 = 62.50%, 3 = 68.75%, 4 = 75%, 5 = 81.25%, 6 = 87.50%,
+ 7 = 93.75%, 8 = 100%, 9 = 106.25%, 10 = 112.50%, 11 = 118.75%, 12 = 125%,
+ 13 = 131.25%, 14 = 137.50%, 15 = 143.75%, 16 = 150%.
+ enum: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16]
+
required:
- reg

--
2.34.1



2024-01-11 16:48:26

by POPESCU Catalin

[permalink] [raw]
Subject: Re: [PATCH 2/3] dt-bindings: net: dp83826: add ti,cfg-dac-plus binding

Adding more people in CC.

On 11.01.24 17:19, Catalin Popescu wrote:
> Add property ti,cfg-dac-plus to allow for voltage tuning
> of logical level +1 of the MLT-3 encoded data.
>
> Signed-off-by: Catalin Popescu <[email protected]>
> ---
> Documentation/devicetree/bindings/net/ti,dp83822.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/ti,dp83822.yaml b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
> index 2f010333be49..f9b68bde57a4 100644
> --- a/Documentation/devicetree/bindings/net/ti,dp83822.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
> @@ -71,6 +71,15 @@ properties:
> 13 = 131.25%, 14 = 137.50%, 15 = 143.75%, 16 = 150%.
> enum: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16]
>
> + ti,cfg-dac-plus:
> + description: |
> + DP83826 PHY only.
> + Sets the voltage ratio of the logical level +1 for the MLT-3 encoded data.
> + 0 = 50%, 1 = 56.25%, 2 = 62.50%, 3 = 68.75%, 4 = 75%, 5 = 81.25%, 6 = 87.50%,
> + 7 = 93.75%, 8 = 100%, 9 = 106.25%, 10 = 112.50%, 11 = 118.75%, 12 = 125%,
> + 13 = 131.25%, 14 = 137.50%, 15 = 143.75%, 16 = 150%.
> + enum: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16]
> +
> required:
> - reg
>


2024-01-11 17:22:20

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/3] dt-bindings: net: dp83826: add ti,cfg-dac-plus binding

On 11/01/2024 17:19, Catalin Popescu wrote:
> Add property ti,cfg-dac-plus to allow for voltage tuning
> of logical level +1 of the MLT-3 encoded data.
>

Please squash it with previous patch.

Best regards,
Krzysztof


2024-01-11 21:02:27

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH 2/3] dt-bindings: net: dp83826: add ti,cfg-dac-plus binding


On Thu, 11 Jan 2024 17:19:26 +0100, Catalin Popescu wrote:
> Add property ti,cfg-dac-plus to allow for voltage tuning
> of logical level +1 of the MLT-3 encoded data.
>
> Signed-off-by: Catalin Popescu <[email protected]>
> ---
> Documentation/devicetree/bindings/net/ti,dp83822.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/ti,dp83822.yaml: ti,cfg-dac-plus: missing type definition

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


2024-01-12 10:57:15

by POPESCU Catalin

[permalink] [raw]
Subject: Re: [PATCH 2/3] dt-bindings: net: dp83826: add ti,cfg-dac-plus binding

On 11.01.24 18:21, Krzysztof Kozlowski wrote:
> [You don't often get email from [email protected]. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email.
>
>
> On 11/01/2024 17:19, Catalin Popescu wrote:
>> Add property ti,cfg-dac-plus to allow for voltage tuning
>> of logical level +1 of the MLT-3 encoded data.
>>
> Please squash it with previous patch.
OK
>
> Best regards,
> Krzysztof
>

2024-01-13 19:17:37

by kernel test robot

[permalink] [raw]
Subject: Re: [PATCH 2/3] dt-bindings: net: dp83826: add ti,cfg-dac-plus binding

Hi Catalin,

kernel test robot noticed the following build warnings:

[auto build test WARNING on robh/for-next]
[also build test WARNING on net-next/main net/main linus/master v6.7 next-20240112]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Catalin-Popescu/dt-bindings-net-dp83826-add-ti-cfg-dac-plus-binding/20240112-002701
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link: https://lore.kernel.org/r/20240111161927.3689084-2-catalin.popescu%40leica-geosystems.com
patch subject: [PATCH 2/3] dt-bindings: net: dp83826: add ti,cfg-dac-plus binding
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20240114/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

dtcheck warnings: (new ones prefixed by >>)
Documentation/devicetree/bindings/net/ti,dp83822.yaml: ti,cfg-dac-minus: missing type definition
>> Documentation/devicetree/bindings/net/ti,dp83822.yaml: ti,cfg-dac-plus: missing type definition
Documentation/devicetree/bindings/net/snps,dwmac.yaml: mac-mode: missing type definition

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki