2017-08-23 22:39:38

by Stephen Boyd

[permalink] [raw]
Subject: [PATCH] clk: rockchip: Mark rockchip_fractional_approximation static

Silence the sparse warning

clk/rockchip/clk.c:172:6: warning: symbol 'rockchip_fractional_approximation' was not declared. Should it be static?

Cc: Elaine Zhang <[email protected]>
Cc: Heiko Stuebner <[email protected]>
Signed-off-by: Stephen Boyd <[email protected]>
---
drivers/clk/rockchip/clk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/rockchip/clk.c b/drivers/clk/rockchip/clk.c
index b6db79a00602..35dbd63c2f49 100644
--- a/drivers/clk/rockchip/clk.c
+++ b/drivers/clk/rockchip/clk.c
@@ -169,7 +169,7 @@ static int rockchip_clk_frac_notifier_cb(struct notifier_block *nb,
* fractional divider must set that denominator is 20 times larger than
* numerator to generate precise clock frequency.
*/
-void rockchip_fractional_approximation(struct clk_hw *hw,
+static void rockchip_fractional_approximation(struct clk_hw *hw,
unsigned long rate, unsigned long *parent_rate,
unsigned long *m, unsigned long *n)
{
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


2017-08-23 23:08:23

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH] clk: rockchip: Mark rockchip_fractional_approximation static

On 08/23, Stephen Boyd wrote:
> Silence the sparse warning
>
> clk/rockchip/clk.c:172:6: warning: symbol 'rockchip_fractional_approximation' was not declared. Should it be static?
>
> Cc: Elaine Zhang <[email protected]>
> Cc: Heiko Stuebner <[email protected]>
> Signed-off-by: Stephen Boyd <[email protected]>
> ---

Applied to clk-next

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

2017-08-24 08:33:05

by Heiko Stuebner

[permalink] [raw]
Subject: Re: [PATCH] clk: rockchip: Mark rockchip_fractional_approximation static

Am Mittwoch, 23. August 2017, 16:08:19 CEST schrieb Stephen Boyd:
> On 08/23, Stephen Boyd wrote:
> > Silence the sparse warning
> >
> > clk/rockchip/clk.c:172:6: warning: symbol 'rockchip_fractional_approximation' was not declared. Should it be static?
> >
> > Cc: Elaine Zhang <[email protected]>
> > Cc: Heiko Stuebner <[email protected]>
> > Signed-off-by: Stephen Boyd <[email protected]>
> > ---
>
> Applied to clk-next

thanks for catching that.

Heiko