2004-10-09 19:59:38

by Ed Schouten

[permalink] [raw]
Subject: [Patch 2/5] xbox: disable optimization for kernel decompressor

When using the kernel decompressor on a Microsoft Xbox, the system hangs
because of invalid paging requests. When compiling the decompressor with
-O0, we can safely avoid this problem.

You can also download this patch at:
http://linux.g-rave.nl/patches/patch-xbox-optimization.diff
---

Makefile | 7 +++++++
1 files changed, 7 insertions(+)

diff -u -r --new-file linux-2.6.9-rc3/arch/i386/boot/compressed/Makefile
linux-2.6.9-rc3-ed0/arch/i386/boot/compressed/Makefile
--- linux-2.6.9-rc3/arch/i386/boot/compressed/Makefile 2004-09-30
05:05:20.000000000 +0200
+++ linux-2.6.9-rc3-ed0/arch/i386/boot/compressed/Makefile 2004-10-09
19:38:25.084610000 +0200
@@ -7,6 +7,13 @@
targets := vmlinux vmlinux.bin vmlinux.bin.gz head.o misc.o piggy.o
EXTRA_AFLAGS := -traditional

+# Microsoft Xbox workaround:
+# Xbox v1.1+ crashes while decompressing the kernel when paging is off.
+# By disabling optimization we can fix this.
+ifeq ($(CONFIG_X86_XBOX),y)
+ CFLAGS_misc.o := -O0
+endif
+
LDFLAGS_vmlinux := -Ttext $(IMAGE_OFFSET) -e startup_32

$(obj)/vmlinux: $(obj)/head.o $(obj)/misc.o $(obj)/piggy.o FORCE


2004-10-12 20:54:17

by Pavel Machek

[permalink] [raw]
Subject: Re: [Patch 2/5] xbox: disable optimization for kernel decompressor

Hi!

> When using the kernel decompressor on a Microsoft Xbox, the system hangs
> because of invalid paging requests. When compiling the decompressor with
> -O0, we can safely avoid this problem.

This is probably workaround, not a real bugfix, right? Fix gcc, or
find out what is really wrong and put it in the comment...
Pavel

--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!