2023-09-19 19:01:41

by Rafael J. Wysocki

Subject: [PATCH v1] thermal: core: Drop redundant trips check from for_each_thermal_trip()

From: Rafael J. Wysocki <[email protected]>

It is invalid to call for_each_thermal_trip() on an unregistered thermal
zone anyway, and as per thermal_zone_device_register_with_trips(), the
trips[] table must be present if num_trips is greater than zero for the
given thermal zone.

Hence, the trips check in for_each_thermal_trip() is redundant and so it
can be dropped.

Signed-off-by: Rafael J. Wysocki <[email protected]>
---
drivers/thermal/thermal_trip.c | 3 ---
1 file changed, 3 deletions(-)

Index: linux-pm/drivers/thermal/thermal_trip.c
===================================================================
--- linux-pm.orig/drivers/thermal/thermal_trip.c
+++ linux-pm/drivers/thermal/thermal_trip.c
@@ -17,9 +17,6 @@ int for_each_thermal_trip(struct thermal

lockdep_assert_held(&tz->lock);

- if (!tz->trips)
- return -ENODATA;
-
for (i = 0; i < tz->num_trips; i++) {
ret = cb(&tz->trips[i], data);
if (ret)

2023-09-26 17:20:48

by Daniel Lezcano

Subject: Re: [PATCH v1] thermal: core: Drop redundant trips check from for_each_thermal_trip()

On 19/09/2023 20:59, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <[email protected]>
>
> It is invalid to call for_each_thermal_trip() on an unregistered thermal
> zone anyway, and as per thermal_zone_device_register_with_trips(), the
> trips[] table must be present if num_trips is greater than zero for the
> given thermal zone.
>
> Hence, the trips check in for_each_thermal_trip() is redundant and so it
> can be dropped.
>
> Signed-off-by: Rafael J. Wysocki <[email protected]>
> ---

Acked-by: Daniel Lezcano <[email protected]>

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog