2017-08-30 17:15:32

by Colin King

Subject: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"

From: Colin Ian King <[email protected]>

Trivial fix to typos in printf error messages:
"conenct" -> "connect"
"listeen" -> "listen"

thanks to Daniel Borkmann for spotting one of these mistakes

Signed-off-by: Colin Ian King <[email protected]>
---
tools/testing/selftests/bpf/test_maps.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/bpf/test_maps.c b/tools/testing/selftests/bpf/test_maps.c
index 7059bb315a10..4acc772a28c0 100644
--- a/tools/testing/selftests/bpf/test_maps.c
+++ b/tools/testing/selftests/bpf/test_maps.c
@@ -504,7 +504,7 @@ static void test_sockmap(int tasks, void *data)
}
err = listen(sfd[i], 32);
if (err < 0) {
- printf("failed to listeen\n");
+ printf("failed to listen\n");
goto out;
}
}
@@ -525,7 +525,7 @@ static void test_sockmap(int tasks, void *data)
addr.sin_port = htons(ports[i - 2]);
err = connect(sfd[i], (struct sockaddr *)&addr, sizeof(addr));
if (err) {
- printf("failed to conenct\n");
+ printf("failed to connect\n");
goto out;
}
}
--
2.14.1

2017-08-30 17:32:09

by John Fastabend

Subject: Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"

On 08/30/2017 10:15 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Trivial fix to typos in printf error messages:
> "conenct" -> "connect"
> "listeen" -> "listen"
>
> thanks to Daniel Borkmann for spotting one of these mistakes
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---

Thanks. Even though its a spelling typo best to add fixes tag
I think.

Fixes: 6f6d33f3b3d0 ("bpf: selftests add sockmap tests")
Acked-by: John Fastabend <[email protected]>

2017-08-30 18:47:18

by Daniel Borkmann

Subject: Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"

On 08/30/2017 07:15 PM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Trivial fix to typos in printf error messages:
> "conenct" -> "connect"
> "listeen" -> "listen"
>
> thanks to Daniel Borkmann for spotting one of these mistakes
>
> Signed-off-by: Colin Ian King <[email protected]>

Acked-by: Daniel Borkmann <[email protected]>

2017-08-30 20:13:50

by Shuah Khan

Subject: Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"

On 08/30/2017 12:47 PM, Daniel Borkmann wrote:
> On 08/30/2017 07:15 PM, Colin King wrote:
>> From: Colin Ian King <[email protected]>
>>
>> Trivial fix to typos in printf error messages:
>> "conenct" -> "connect"
>> "listeen" -> "listen"
>>
>> thanks to Daniel Borkmann for spotting one of these mistakes
>>
>> Signed-off-by: Colin Ian King <[email protected]>
>
> Acked-by: Daniel Borkmann <[email protected]>
>
>

I can get this into 4.14-rc1 unless it should go through net-next
for dependencies. In which case,

Acked-by: Shuah Khan <[email protected]>

thanks,
-- Shuah

2017-08-30 20:24:21

by Daniel Borkmann

Subject: Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"

On 08/30/2017 10:13 PM, Shuah Khan wrote:
> On 08/30/2017 12:47 PM, Daniel Borkmann wrote:
>> On 08/30/2017 07:15 PM, Colin King wrote:
>>> From: Colin Ian King <[email protected]>
>>>
>>> Trivial fix to typos in printf error messages:
>>> "conenct" -> "connect"
>>> "listeen" -> "listen"
>>>
>>> thanks to Daniel Borkmann for spotting one of these mistakes
>>>
>>> Signed-off-by: Colin Ian King <[email protected]>
>>
>> Acked-by: Daniel Borkmann <[email protected]>
>
> I can get this into 4.14-rc1 unless it should go through net-next
> for dependencies. In which case,

Yeah, it does depends on work sitting in net-next so easier
to go that route.

Thanks,
Daniel

2017-08-30 22:33:01

by David Miller

Subject: Re: [PATCH][net-next][V3] bpf: test_maps: fix typos, "conenct" and "listeen"

From: Colin King <[email protected]>
Date: Wed, 30 Aug 2017 18:15:25 +0100

> From: Colin Ian King <[email protected]>
>
> Trivial fix to typos in printf error messages:
> "conenct" -> "connect"
> "listeen" -> "listen"
>
> thanks to Daniel Borkmann for spotting one of these mistakes
>
> Signed-off-by: Colin Ian King <[email protected]>

Applied.