2017-11-02 22:43:36

by Daniel Borkmann

[permalink] [raw]
Subject: Re: [PATCH][net-next] net: sched: cls_bpf: use bitwise & rather than logical && on gen_flags

On 11/02/2017 09:04 PM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Currently gen_flags is being operated on by a logical && operator rather
> than a bitwise & operator. This looks incorrect as these should be bit
> flag operations. Fix this.
>
> Detected by CoverityScan, CID#1460305 ("Logical vs. bitwise operator")
>
> Fixes: 3f7889c4c79b ("net: sched: cls_bpf: call block callbacks for offload)
> Signed-off-by: Colin Ian King <[email protected]>

Acked-by: Daniel Borkmann <[email protected]>

From 1582986031580447277@xxx Thu Nov 02 20:05:21 +0000 2017
X-GM-THRID: 1582986031580447277
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread