2024-03-16 11:52:57

by Christophe Leroy

[permalink] [raw]
Subject: [PATCH] mm: Remove guard around pgd_offset_k() macro

The last architecture redefining pgd_offset_k() was IA64 and it was
removed by commit cf8e8658100d ("arch: Remove Itanium (IA-64)
architecture")

There is no need anymore to guard generic version of pgd_offset_k()
with #ifndef pgd_offset_k

Signed-off-by: Christophe Leroy <[email protected]>
---
include/linux/pgtable.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h
index 85fc7554cd52..bd9c7180718c 100644
--- a/include/linux/pgtable.h
+++ b/include/linux/pgtable.h
@@ -149,9 +149,7 @@ static inline pgd_t *pgd_offset_pgd(pgd_t *pgd, unsigned long address)
* a shortcut which implies the use of the kernel's pgd, instead
* of a process's
*/
-#ifndef pgd_offset_k
#define pgd_offset_k(address) pgd_offset(&init_mm, (address))
-#endif

/*
* In many cases it is known that a virtual address is mapped at PMD or PTE
--
2.43.0



2024-03-18 12:19:56

by David Hildenbrand

[permalink] [raw]
Subject: Re: [PATCH] mm: Remove guard around pgd_offset_k() macro

On 16.03.24 12:52, Christophe Leroy wrote:
> The last architecture redefining pgd_offset_k() was IA64 and it was
> removed by commit cf8e8658100d ("arch: Remove Itanium (IA-64)
> architecture")
>
> There is no need anymore to guard generic version of pgd_offset_k()
> with #ifndef pgd_offset_k
>
> Signed-off-by: Christophe Leroy <[email protected]>
> ---
> include/linux/pgtable.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h
> index 85fc7554cd52..bd9c7180718c 100644
> --- a/include/linux/pgtable.h
> +++ b/include/linux/pgtable.h
> @@ -149,9 +149,7 @@ static inline pgd_t *pgd_offset_pgd(pgd_t *pgd, unsigned long address)
> * a shortcut which implies the use of the kernel's pgd, instead
> * of a process's
> */
> -#ifndef pgd_offset_k
> #define pgd_offset_k(address) pgd_offset(&init_mm, (address))
> -#endif
>
> /*
> * In many cases it is known that a virtual address is mapped at PMD or PTE

Reviewed-by: David Hildenbrand <[email protected]>

--
Cheers,

David / dhildenb