2024-05-18 23:29:30

by Jeff Johnson

Subject: [PATCH] rcu: add missing MODULE_DESCRIPTION() macros

Fix the following 'make W=1' warnings:

WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/rcu/rcutorture.o
WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/rcu/rcuscale.o
WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/rcu/refscale.o

Signed-off-by: Jeff Johnson <[email protected]>
---
kernel/rcu/rcuscale.c | 1 +
kernel/rcu/rcutorture.c | 1 +
kernel/rcu/refscale.c | 1 +
3 files changed, 3 insertions(+)

diff --git a/kernel/rcu/rcuscale.c b/kernel/rcu/rcuscale.c
index 8db4fedaaa1e..b53a9e8f5904 100644
--- a/kernel/rcu/rcuscale.c
+++ b/kernel/rcu/rcuscale.c
@@ -42,6 +42,7 @@

#include "rcu.h"

+MODULE_DESCRIPTION("Read-Copy Update module-based scalability-test facility");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Paul E. McKenney <[email protected]>");

diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
index 807fbf6123a7..b0d8d06ab7a8 100644
--- a/kernel/rcu/rcutorture.c
+++ b/kernel/rcu/rcutorture.c
@@ -51,6 +51,7 @@

#include "rcu.h"

+MODULE_DESCRIPTION("Read-Copy Update module-based torture test facility");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Paul E. McKenney <[email protected]> and Josh Triplett <[email protected]>");

diff --git a/kernel/rcu/refscale.c b/kernel/rcu/refscale.c
index 2c2648a3ad30..f4ea5b1ec068 100644
--- a/kernel/rcu/refscale.c
+++ b/kernel/rcu/refscale.c
@@ -63,6 +63,7 @@ do { \

#define SCALEOUT_ERRSTRING(s, x...) pr_alert("%s" SCALE_FLAG "!!! " s "\n", scale_type, ## x)

+MODULE_DESCRIPTION("Scalability test for object reference mechanisms");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Joel Fernandes (Google) <[email protected]>");


---
base-commit: 674143feb6a8c02d899e64e2ba0f992896afd532
change-id: 20240518-rcu-7d1939bd9205

2024-05-19 00:45:41

by Paul E. McKenney

Subject: Re: [PATCH] rcu: add missing MODULE_DESCRIPTION() macros

On Sat, May 18, 2024 at 04:28:08PM -0700, Jeff Johnson wrote:
> Fix the following 'make W=1' warnings:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/rcu/rcutorture.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/rcu/rcuscale.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in kernel/rcu/refscale.o
>
> Signed-off-by: Jeff Johnson <[email protected]>

I applied and pushed both patches, thank you!

Thanx, Paul

> ---
> kernel/rcu/rcuscale.c | 1 +
> kernel/rcu/rcutorture.c | 1 +
> kernel/rcu/refscale.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/kernel/rcu/rcuscale.c b/kernel/rcu/rcuscale.c
> index 8db4fedaaa1e..b53a9e8f5904 100644
> --- a/kernel/rcu/rcuscale.c
> +++ b/kernel/rcu/rcuscale.c
> @@ -42,6 +42,7 @@
>
> #include "rcu.h"
>
> +MODULE_DESCRIPTION("Read-Copy Update module-based scalability-test facility");
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Paul E. McKenney <[email protected]>");
>
> diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
> index 807fbf6123a7..b0d8d06ab7a8 100644
> --- a/kernel/rcu/rcutorture.c
> +++ b/kernel/rcu/rcutorture.c
> @@ -51,6 +51,7 @@
>
> #include "rcu.h"
>
> +MODULE_DESCRIPTION("Read-Copy Update module-based torture test facility");
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Paul E. McKenney <[email protected]> and Josh Triplett <[email protected]>");
>
> diff --git a/kernel/rcu/refscale.c b/kernel/rcu/refscale.c
> index 2c2648a3ad30..f4ea5b1ec068 100644
> --- a/kernel/rcu/refscale.c
> +++ b/kernel/rcu/refscale.c
> @@ -63,6 +63,7 @@ do { \
>
> #define SCALEOUT_ERRSTRING(s, x...) pr_alert("%s" SCALE_FLAG "!!! " s "\n", scale_type, ## x)
>
> +MODULE_DESCRIPTION("Scalability test for object reference mechanisms");
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Joel Fernandes (Google) <[email protected]>");
>
>
> ---
> base-commit: 674143feb6a8c02d899e64e2ba0f992896afd532
> change-id: 20240518-rcu-7d1939bd9205
>