Hi all,
Commits
cae00f2ab011 ("Revert "hrtimer: Report offline hrtimer enqueue"")
9addc18fe8cd ("Revert "rcu-tasks: Eliminate deadlocks involving do_exit() and RCU tasks"")
are missing a Signed-off-by from their author and commiter.
Reverts are commits as well.
--
Cheers,
Stephen Rothwell
On Thu, Feb 08, 2024 at 07:39:19AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> Commits
>
> cae00f2ab011 ("Revert "hrtimer: Report offline hrtimer enqueue"")
> 9addc18fe8cd ("Revert "rcu-tasks: Eliminate deadlocks involving do_exit() and RCU tasks"")
>
> are missing a Signed-off-by from their author and commiter.
>
> Reverts are commits as well.
Apologies, will fix!
Thanx, Paul
On Wed, Nov 29, 2017 at 11:29:03AM +0800, Lihao Liang wrote:
>
>
> On 2017/11/29 11:14, Hanjun Guo wrote:
> > Hi Lihao,
> >
> > On 2017/11/29 10:48, Lihao Liang wrote:
> >> Hi Paul,
> >>
> >> Signed-off-by: Lihao Liang <[email protected]>
> >
> > ...
> >
> >>
> >> Many thanks,
> >> Lihao.
> >>
> >> On 2017/11/29 9:14, Paul E. McKenney wrote:
> >>> On Wed, Nov 29, 2017 at 11:51:51AM +1100, Stephen Rothwell wrote:
> >>>> Hi Paul,
> >>>>
> >>>> Commit
> >>>>
> >>>> d7e182c9c324 ("rcu: Remove unnecessary spinlock in rcu_boot_init_percpu_data()")
> >>>>
> >>>> is missing a Signed-off-by from its author.
> >>> Good catch, Stephen!
> >>>
> >>> Lihao, would you please get me you Signed-off-by? The patch is below.
> >>>
> >>> Thanx, Paul
> >>>
> >>> ------------------------------------------------------------------------
> >>>
> >>> commit d7e182c9c32480c1f579dd888ac50e88bfb39596
> >>> Author: Liang Lihao <[email protected]>
> >
> > So it's better to keep the author and Signed-off-by the same :)
> >
>
> Sure. Paul and Stephen, please use
>
> Signed-off-by: Lihao Liang <[email protected]>
Updated, thank you both!
Thanx, Paul
> Many thanks,
> Lihao.
>
> > Thanks
> > Hanjun
> >
> >
> > .
> >
>
From 1585369583273074968@xxx Wed Nov 29 03:30:53 +0000 2017
X-GM-THRID: 1585359635963962041
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread
On 2017/11/29 11:14, Hanjun Guo wrote:
> Hi Lihao,
>
> On 2017/11/29 10:48, Lihao Liang wrote:
>> Hi Paul,
>>
>> Signed-off-by: Lihao Liang <[email protected]>
>
> ...
>
>>
>> Many thanks,
>> Lihao.
>>
>> On 2017/11/29 9:14, Paul E. McKenney wrote:
>>> On Wed, Nov 29, 2017 at 11:51:51AM +1100, Stephen Rothwell wrote:
>>>> Hi Paul,
>>>>
>>>> Commit
>>>>
>>>> d7e182c9c324 ("rcu: Remove unnecessary spinlock in rcu_boot_init_percpu_data()")
>>>>
>>>> is missing a Signed-off-by from its author.
>>> Good catch, Stephen!
>>>
>>> Lihao, would you please get me you Signed-off-by? The patch is below.
>>>
>>> Thanx, Paul
>>>
>>> ------------------------------------------------------------------------
>>>
>>> commit d7e182c9c32480c1f579dd888ac50e88bfb39596
>>> Author: Liang Lihao <[email protected]>
>
> So it's better to keep the author and Signed-off-by the same :)
>
Sure. Paul and Stephen, please use
Signed-off-by: Lihao Liang <[email protected]>
Many thanks,
Lihao.
> Thanks
> Hanjun
>
>
> .
>
From 1585368656648858804@xxx Wed Nov 29 03:16:09 +0000 2017
X-GM-THRID: 1585359635963962041
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread
Hi Lihao,
On 2017/11/29 10:48, Lihao Liang wrote:
> Hi Paul,
>
> Signed-off-by: Lihao Liang <[email protected]>
...
>
> Many thanks,
> Lihao.
>
> On 2017/11/29 9:14, Paul E. McKenney wrote:
>> On Wed, Nov 29, 2017 at 11:51:51AM +1100, Stephen Rothwell wrote:
>>> Hi Paul,
>>>
>>> Commit
>>>
>>> d7e182c9c324 ("rcu: Remove unnecessary spinlock in rcu_boot_init_percpu_data()")
>>>
>>> is missing a Signed-off-by from its author.
>> Good catch, Stephen!
>>
>> Lihao, would you please get me you Signed-off-by? The patch is below.
>>
>> Thanx, Paul
>>
>> ------------------------------------------------------------------------
>>
>> commit d7e182c9c32480c1f579dd888ac50e88bfb39596
>> Author: Liang Lihao <[email protected]>
So it's better to keep the author and Signed-off-by the same :)
Thanks
Hanjun
From 1585367041049340209@xxx Wed Nov 29 02:50:29 +0000 2017
X-GM-THRID: 1585359635963962041
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread
Hi Paul,
Signed-off-by: Lihao Liang <[email protected]>
Many thanks,
Lihao.
On 2017/11/29 9:14, Paul E. McKenney wrote:
> On Wed, Nov 29, 2017 at 11:51:51AM +1100, Stephen Rothwell wrote:
>> Hi Paul,
>>
>> Commit
>>
>> d7e182c9c324 ("rcu: Remove unnecessary spinlock in rcu_boot_init_percpu_data()")
>>
>> is missing a Signed-off-by from its author.
>
> Good catch, Stephen!
>
> Lihao, would you please get me you Signed-off-by? The patch is below.
>
> Thanx, Paul
>
> ------------------------------------------------------------------------
>
> commit d7e182c9c32480c1f579dd888ac50e88bfb39596
> Author: Liang Lihao <[email protected]>
> Date: Wed Nov 22 19:00:55 2017 +0000
>
> rcu: Remove unnecessary spinlock in rcu_boot_init_percpu_data()
>
> Since rcu_boot_init_percpu_data() is only called at boot time,
> there is no data race and spinlock is not needed.
>
> Signed-off-by: Paul E. McKenney <[email protected]>
>
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index 69722817d6d6..0abe1db53d70 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -3636,12 +3636,9 @@ static void rcu_init_new_rnp(struct rcu_node *rnp_leaf)
> static void __init
> rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
> {
> - unsigned long flags;
> struct rcu_data *rdp = per_cpu_ptr(rsp->rda, cpu);
> - struct rcu_node *rnp = rcu_get_root(rsp);
>
> /* Set up local state, ensuring consistent view of global state. */
> - raw_spin_lock_irqsave_rcu_node(rnp, flags);
> rdp->grpmask = leaf_node_cpu_bit(rdp->mynode, cpu);
> rdp->dynticks = &per_cpu(rcu_dynticks, cpu);
> WARN_ON_ONCE(rdp->dynticks->dynticks_nesting != 1);
> @@ -3649,7 +3646,6 @@ rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
> rdp->cpu = cpu;
> rdp->rsp = rsp;
> rcu_boot_init_nocb_percpu_data(rdp);
> - raw_spin_unlock_irqrestore_rcu_node(rnp, flags);
> }
>
> /*
>
>
>
From 1585361138147426109@xxx Wed Nov 29 01:16:39 +0000 2017
X-GM-THRID: 1585359635963962041
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread
On Wed, Nov 29, 2017 at 11:51:51AM +1100, Stephen Rothwell wrote:
> Hi Paul,
>
> Commit
>
> d7e182c9c324 ("rcu: Remove unnecessary spinlock in rcu_boot_init_percpu_data()")
>
> is missing a Signed-off-by from its author.
Good catch, Stephen!
Lihao, would you please get me you Signed-off-by? The patch is below.
Thanx, Paul
------------------------------------------------------------------------
commit d7e182c9c32480c1f579dd888ac50e88bfb39596
Author: Liang Lihao <[email protected]>
Date: Wed Nov 22 19:00:55 2017 +0000
rcu: Remove unnecessary spinlock in rcu_boot_init_percpu_data()
Since rcu_boot_init_percpu_data() is only called at boot time,
there is no data race and spinlock is not needed.
Signed-off-by: Paul E. McKenney <[email protected]>
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index 69722817d6d6..0abe1db53d70 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -3636,12 +3636,9 @@ static void rcu_init_new_rnp(struct rcu_node *rnp_leaf)
static void __init
rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
{
- unsigned long flags;
struct rcu_data *rdp = per_cpu_ptr(rsp->rda, cpu);
- struct rcu_node *rnp = rcu_get_root(rsp);
/* Set up local state, ensuring consistent view of global state. */
- raw_spin_lock_irqsave_rcu_node(rnp, flags);
rdp->grpmask = leaf_node_cpu_bit(rdp->mynode, cpu);
rdp->dynticks = &per_cpu(rcu_dynticks, cpu);
WARN_ON_ONCE(rdp->dynticks->dynticks_nesting != 1);
@@ -3649,7 +3646,6 @@ rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
rdp->cpu = cpu;
rdp->rsp = rsp;
rcu_boot_init_nocb_percpu_data(rdp);
- raw_spin_unlock_irqrestore_rcu_node(rnp, flags);
}
/*
From 1585359635963962041@xxx Wed Nov 29 00:52:47 +0000 2017
X-GM-THRID: 1585359635963962041
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread