2017-12-22 01:41:06

by Lu Baolu

[permalink] [raw]
Subject: [PATCH 1/1] usb: xhci: dbc: Add SPDX identifiers to dbc files

Update the xhci dbc files with the correct SPDX license identifiers.

Fixes: dfba2174dc42 ("usb: xhci: Add DbC support in xHCI driver")
Signed-off-by: Lu Baolu <[email protected]>
---
drivers/usb/host/xhci-dbgcap.c | 1 +
drivers/usb/host/xhci-dbgcap.h | 2 +-
drivers/usb/host/xhci-dbgtty.c | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/host/xhci-dbgcap.c b/drivers/usb/host/xhci-dbgcap.c
index 452df0f..beea567 100644
--- a/drivers/usb/host/xhci-dbgcap.c
+++ b/drivers/usb/host/xhci-dbgcap.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
/**
* xhci-dbgcap.c - xHCI debug capability support
*
diff --git a/drivers/usb/host/xhci-dbgcap.h b/drivers/usb/host/xhci-dbgcap.h
index e66ea07..6c8906d 100644
--- a/drivers/usb/host/xhci-dbgcap.h
+++ b/drivers/usb/host/xhci-dbgcap.h
@@ -1,4 +1,4 @@
-
+// SPDX-License-Identifier: GPL-2.0
/**
* xhci-dbgcap.h - xHCI debug capability support
*
diff --git a/drivers/usb/host/xhci-dbgtty.c b/drivers/usb/host/xhci-dbgtty.c
index 8d47b6f..033cc0e 100644
--- a/drivers/usb/host/xhci-dbgtty.c
+++ b/drivers/usb/host/xhci-dbgtty.c
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
/**
* xhci-dbgtty.c - tty glue for xHCI debug capability
*
--
2.7.4


2017-12-22 08:33:25

by Philippe Ombredanne

[permalink] [raw]
Subject: Re: [PATCH 1/1] usb: xhci: dbc: Add SPDX identifiers to dbc files

Lu,

On Fri, Dec 22, 2017 at 2:34 AM, Lu Baolu <[email protected]> wrote:
> Update the xhci dbc files with the correct SPDX license identifiers.
>
> Fixes: dfba2174dc42 ("usb: xhci: Add DbC support in xHCI driver")
> Signed-off-by: Lu Baolu <[email protected]>
> ---
> drivers/usb/host/xhci-dbgcap.c | 1 +
> drivers/usb/host/xhci-dbgcap.h | 2 +-
> drivers/usb/host/xhci-dbgtty.c | 1 +
> 3 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-dbgcap.c b/drivers/usb/host/xhci-dbgcap.c
> index 452df0f..beea567 100644
> --- a/drivers/usb/host/xhci-dbgcap.c
> +++ b/drivers/usb/host/xhci-dbgcap.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
> /**
> * xhci-dbgcap.c - xHCI debug capability support
> *
> diff --git a/drivers/usb/host/xhci-dbgcap.h b/drivers/usb/host/xhci-dbgcap.h
> index e66ea07..6c8906d 100644
> --- a/drivers/usb/host/xhci-dbgcap.h
> +++ b/drivers/usb/host/xhci-dbgcap.h
> @@ -1,4 +1,4 @@
> -
> +// SPDX-License-Identifier: GPL-2.0

Headers should be using plain C style comments per Thomas
documentation patches.
> +/* SPDX-License-Identifier: GPL-2.0 */

> /**
> * xhci-dbgcap.h - xHCI debug capability support
> *
> diff --git a/drivers/usb/host/xhci-dbgtty.c b/drivers/usb/host/xhci-dbgtty.c
> index 8d47b6f..033cc0e 100644
> --- a/drivers/usb/host/xhci-dbgtty.c
> +++ b/drivers/usb/host/xhci-dbgtty.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
> /**
> * xhci-dbgtty.c - tty glue for xHCI debug capability
> *

--
Cordially
Philippe Ombredanne

2017-12-23 07:46:47

by Lu Baolu

[permalink] [raw]
Subject: Re: [PATCH 1/1] usb: xhci: dbc: Add SPDX identifiers to dbc files

Hi,

On 12/22/2017 04:32 PM, Philippe Ombredanne wrote:
> Lu,
>
> On Fri, Dec 22, 2017 at 2:34 AM, Lu Baolu <[email protected]> wrote:
>> Update the xhci dbc files with the correct SPDX license identifiers.
>>
>> Fixes: dfba2174dc42 ("usb: xhci: Add DbC support in xHCI driver")
>> Signed-off-by: Lu Baolu <[email protected]>
>> ---
>> drivers/usb/host/xhci-dbgcap.c | 1 +
>> drivers/usb/host/xhci-dbgcap.h | 2 +-
>> drivers/usb/host/xhci-dbgtty.c | 1 +
>> 3 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/host/xhci-dbgcap.c b/drivers/usb/host/xhci-dbgcap.c
>> index 452df0f..beea567 100644
>> --- a/drivers/usb/host/xhci-dbgcap.c
>> +++ b/drivers/usb/host/xhci-dbgcap.c
>> @@ -1,3 +1,4 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> /**
>> * xhci-dbgcap.c - xHCI debug capability support
>> *
>> diff --git a/drivers/usb/host/xhci-dbgcap.h b/drivers/usb/host/xhci-dbgcap.h
>> index e66ea07..6c8906d 100644
>> --- a/drivers/usb/host/xhci-dbgcap.h
>> +++ b/drivers/usb/host/xhci-dbgcap.h
>> @@ -1,4 +1,4 @@
>> -
>> +// SPDX-License-Identifier: GPL-2.0
> Headers should be using plain C style comments per Thomas
> documentation patches.

Thanks. I will send a v2 for this.

Best regards,
Lu Baolu

>> +/* SPDX-License-Identifier: GPL-2.0 */
>> /**
>> * xhci-dbgcap.h - xHCI debug capability support
>> *
>> diff --git a/drivers/usb/host/xhci-dbgtty.c b/drivers/usb/host/xhci-dbgtty.c
>> index 8d47b6f..033cc0e 100644
>> --- a/drivers/usb/host/xhci-dbgtty.c
>> +++ b/drivers/usb/host/xhci-dbgtty.c
>> @@ -1,3 +1,4 @@
>> +// SPDX-License-Identifier: GPL-2.0
>> /**
>> * xhci-dbgtty.c - tty glue for xHCI debug capability
>> *