2022-12-15 01:35:57

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: Fixes tag needs some work in the nfs tree

---

Hi all,

In commit

405ab45b5afa ("SUNRPC: ensure the matching upcall is in-flight upon downcall")

Fixes tag

Fixes: Commit 9130b8dbc6ac ("SUNRPC: allow for upcalls for the same uid

has these problem(s):

- leading word 'Commit' unexpected
- Subject has leading but no trailing parentheses
- Subject has leading but no trailing quotes
- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'

Please do not split Fixes tags over more than one line.

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2022-12-15 23:34:02

by Trond Myklebust

[permalink] [raw]

Subject: Re: linux-next: Fixes tag needs some work in the nfs tree

---

> On Dec 14, 2022, at 19:54, Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> In commit
>
> 405ab45b5afa ("SUNRPC: ensure the matching upcall is in-flight upon downcall")
>
> Fixes tag
>
> Fixes: Commit 9130b8dbc6ac ("SUNRPC: allow for upcalls for the same uid
>
> has these problem(s):
>
> - leading word 'Commit' unexpected
> - Subject has leading but no trailing parentheses
> - Subject has leading but no trailing quotes
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
> Please do not split Fixes tags over more than one line.
>
> --
> Cheers,
> Stephen Rothwell

Thanks Stephen! Sorry about missing that.
I’ve fixed up the offending line and pushed out a new linux-next branch.

_________________________________
Trond Myklebust
Linux NFS client maintainer, Hammerspace
[email protected]